GithubHelp home page GithubHelp logo

Comments (11)

fiftyeightandeight avatar fiftyeightandeight commented on May 27, 2024

Error Codes

  • Ensure every error code is defined as "ERR-"
  • Remove unnecessary/unused error codes from contracts
  • Update the Gitbook

Source Code Documentation

Source code comments should follow the following syntax:

;; @desc <description of the contract/function>
;; @restricted <describe here is the contract/function use is restricted to certain owners>
;; @param <name>; <description of parameter>
;; @returns <return type> (e.g. (response bool uint))
;; @post <describe post condition>

from alex-v1.

fiftyeightandeight avatar fiftyeightandeight commented on May 27, 2024

Hi @SaadTahirTintash , in between your assignments, can you please follow up on this. Thank you.

from alex-v1.

SaadTahirTintash avatar SaadTahirTintash commented on May 27, 2024

Do you need me to verify that all the Error Codes are present in the code? The error code ERR-STX-TRANSFER-FAILED was added by me when adding token-wstx. It has a wrong error code of err u3001 for now. It should be err u9003 according to Gitbook

from alex-v1.

fiftyeightandeight avatar fiftyeightandeight commented on May 27, 2024

Do you need me to verify that all the Error Codes are present in the code? The error code ERR-STX-TRANSFER-FAILED was added by me when adding token-wstx. It has a wrong error code of err u3001 for now. It should be err u9003 according to Gitbook

Yes, please.

from alex-v1.

SaadTahirTintash avatar SaadTahirTintash commented on May 27, 2024

I've created a change request on Gitbook with some comments. I've cross checked all the errors in the contracts and refactored them as well. The code is pushed to #349 branch

from alex-v1.

fiftyeightandeight avatar fiftyeightandeight commented on May 27, 2024

Hi @SaadTahirTintash I merged your changes to Gitbook. Please continue working on the rest of the issue.
Thank you.

from alex-v1.

SaadTahirTintash avatar SaadTahirTintash commented on May 27, 2024

Remove unnecessary/unused error codes from contracts Do you need me to do this as well? I haven't checked it out thoroughly yet.

from alex-v1.

fiftyeightandeight avatar fiftyeightandeight commented on May 27, 2024

Yes, please. I want you to follow up with everything on the checklist.

from alex-v1.

SaadTahirTintash avatar SaadTahirTintash commented on May 27, 2024

Remove unnecessary/unused error codes from contracts is fixed now

from alex-v1.

naila24 avatar naila24 commented on May 27, 2024

Pull request for source code documentation is created and can be found here

from alex-v1.

naila24 avatar naila24 commented on May 27, 2024

Pull request for duplicate error codes removal can be found here

from alex-v1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.