Comments (11)
Error Codes
- Ensure every error code is defined as "ERR-"
- Remove unnecessary/unused error codes from contracts
- Update the Gitbook
Source Code Documentation
Source code comments should follow the following syntax:
;; @desc <description of the contract/function>
;; @restricted <describe here is the contract/function use is restricted to certain owners>
;; @param <name>; <description of parameter>
;; @returns <return type> (e.g. (response bool uint))
;; @post <describe post condition>
- Update/add the source code comments
- Update https://docs.alexgo.io/developers/smart-contracts/apis
from alex-v1.
Hi @SaadTahirTintash , in between your assignments, can you please follow up on this. Thank you.
from alex-v1.
Do you need me to verify that all the Error Codes are present in the code? The error code ERR-STX-TRANSFER-FAILED
was added by me when adding token-wstx
. It has a wrong error code of err u3001
for now. It should be err u9003
according to Gitbook
from alex-v1.
Do you need me to verify that all the Error Codes are present in the code? The error code
ERR-STX-TRANSFER-FAILED
was added by me when addingtoken-wstx
. It has a wrong error code oferr u3001
for now. It should beerr u9003
according to Gitbook
Yes, please.
from alex-v1.
I've created a change request on Gitbook with some comments. I've cross checked all the errors in the contracts and refactored them as well. The code is pushed to #349 branch
from alex-v1.
Hi @SaadTahirTintash I merged your changes to Gitbook. Please continue working on the rest of the issue.
Thank you.
from alex-v1.
Remove unnecessary/unused error codes from contracts
Do you need me to do this as well? I haven't checked it out thoroughly yet.
from alex-v1.
Yes, please. I want you to follow up with everything on the checklist.
from alex-v1.
Remove unnecessary/unused error codes from contracts
is fixed now
from alex-v1.
Pull request for source code documentation is created and can be found here
from alex-v1.
Pull request for duplicate error codes removal can be found here
from alex-v1.
Related Issues (20)
- feat(faucet): add `alex` test token
- feat: fixed-weight-pool swap routing
- feat: LP token staking
- feat: semi-fungible-token to implement `transfer` without optional memo and `transfer-memo` with memo HOT 8
- feat: `trait-flash-loan-user.flash-loan-user-trait` implements (execute (<ft-trait> uint (optional (buff 16))) (response bool uint)) HOT 2
- fix: clean-up / removal of unused fixed-point functions from contracts HOT 4
- fix: `map`/`fold` with trait reference passed HOT 1
- fix: limit `yield-token-pool` size to % of `fixed-weight-pool` HOT 1
- Please cancel KYC
- fix(futures-pool): tokens to be held by vault HOT 1
- verify percent in reduce-position is better HOT 2
- feat(weighted-equation): uniswap implementation
- feat(fixed-weight-pool): uniswap implementation
- feat(fixed-weight-pool): swap-helper
- feat: oracle-helper
- feat: simplie-weight-pool-wstx
- ALEX banana info page typo HOT 1
- Missing `proposal-trait.clar` file HOT 4
- crp: `get-weight-x` ensures `yield-supply` <= `balance-y`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alex-v1.