Comments (7)
I have rolled back the .length and .name addition for now.
I have deprecated 3.1.0 and published 3.1.1 which does not modify the function properties. This gives us some breathing room to think about this a bit more and test approaches
from memoize-one.
@alexreardon That fix worked! Thank you for such a quick turnaround :)
from memoize-one.
Damn. Thanks.
@theKashey looks like the best path forward for now is to drop our .length (and .name?) modifications
from memoize-one.
I am not keen to try an sniff if we are operating in IE11 - especially as this module can be used in browser or in node. I think for now we should role back this change
from memoize-one.
Or wrap things in a try/catch... thoughts?
from memoize-one.
Would you welcome some eval in your code? https://github.com/blakeembrey/arity
from memoize-one.
@eugene1g can you please try again and let me know how you go? Thanks for picking this up so quickly. Because it was so quick I was able to deprecate 3.1
from memoize-one.
Related Issues (20)
- Memoize not working properly with `NaN` HOT 4
- Memoize not working properly with arrays HOT 2
- Memoize not working properly with objects and custom comparator HOT 1
- React useMemo style API HOT 2
- Doc: please update the performance numbers + the benchmark HOT 3
- Cannot find v5.2.0 via NPM HOT 1
- `5.2.0` introduces a breaking change HOT 28
- MD5 checksum for object parameters HOT 2
- PSA: Intention to remove ie11 support
- Don't allow `resultFn` to resolve to implicit any params HOT 4
- "This expression is not callable" type error when trying to use this package from ESM module HOT 2
- Analysis: 64% of dependency updates in this repository can be merged. HOT 1
- TypeScript errors with modules HOT 3
- Memoizing TypeScript functions with generics
- Does memoize-one support Promises? HOT 3
- TypeError: memoizeOne is not a function HOT 4
- Same parameters, different locations will also rerun HOT 2
- Simple code in TS not working HOT 3
- Memoize one is failing within a test environment. Value is not changed yet memoized function is called. HOT 2
- Misleading documentation HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memoize-one.