Comments (5)
I've created the pull request for this: #13
from venus.
Hi, support for the Linux desktop environment Xfce4 is missing. Can we add it?
Definitely, I'll look into it or if you want - you're welcome to try and add support for it and submit a pull request.
from venus.
Definitely, I'll look into it or if you want - you're welcome to try and add support for it and submit a pull request.
Please take a look at the pull request: #13
from venus.
Definitely, I'll look into it or if you want - you're welcome to try and add support for it and submit a pull request.
Please take a look at the pull request: #13
Awesome, sorry for the wait, I'll take a look at it.
from venus.
Definitely, I'll look into it or if you want - you're welcome to try and add support for it and submit a pull request.
Please take a look at the pull request: #13
So I tested it on Xfce 4.14 and it didn't work for me. The good thing is that I know why.
Your current logic assumes that the property to set the wallpaper is that which contains last-image
as the end of the property and is also the first occurrence since the for-loop breaks when it finds it.
for line in stdout.splitlines():
if line.endswith("last-image"):
subprocess.call(["xfconf-query", "--channel", "xfce4-desktop", "--property", line,"--set", picture_file], **silent)
break
However, when I tried it, that was not the case for my system (tested using Linux mint 19.3). Monitoring Xfce for changes I noticed that the property used for setting the wallpaper for me was
/backdrop/screen0/monitoreDP-1/workspace0/last-image
and there were a few other properties that contained last-image
when listing out all the properties prior to the one that worked to set the wallpaper.
To be more specific, the current logic is using the following property to set the wallpaper on my system which does not change the wallpaper:
/backdrop/screen0/monitor0/last-image
So, the logic needs to be updated so that it works with other configurations before It can be merged. The tricky part is figuring out how to distinguish between configurations so that Venus knows the property to set the image with since I suspect that it will be different based on versions of Xfce4 and monitor setups (currently only accounting for single monitor setups of course). I'll leave the logic up to you, but maybe looking at log files to see how the last image was set could work.
from venus.
Related Issues (16)
- Permanently save images HOT 2
- Support Unsplash collections HOT 2
- Using id originally from unsplash.com to help finding photo source HOT 2
- Cant find a config file HOT 1
- Support Multiple Monitors HOT 2
- Consider outsourcing venus_demo.gif HOT 3
- pywal not implemeted for Darwin HOT 1
- malformatted images from unsplash
- Resolution Settings should filter images and not resize images
- hangs when running on Windows 11 with Python 3.12
- Windows 10 HOT 3
- Baking in a scheduler HOT 4
- Verified working in Gentoo HOT 7
- freebsd support HOT 1
- Not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from venus.