GithubHelp home page GithubHelp logo

Comments (6)

sbellone avatar sbellone commented on September 22, 2024 2

Merged through #799, thanks again! 👍

from algoliasearch-client-csharp.

TomKlotzPro avatar TomKlotzPro commented on September 22, 2024 1

Hey @hognevevle,

Thanks for this feedback, I'll check with the engine-team if we can send a long.

I'll keep you updated about this.

from algoliasearch-client-csharp.

TomKlotzPro avatar TomKlotzPro commented on September 22, 2024 1

Hello @hognevevle,

I've checked with the engine team, and indeed, this should be a long! Do you want to open the PR to update the code ? I could do it but next week. 😞

However, I'm preparing a new minor release for next week, so it fits really well.

from algoliasearch-client-csharp.

hognevevle avatar hognevevle commented on September 22, 2024 1

Opened #777 . Decided to add overloads for IncrementFrom/IncrementSet instead of updating the existing methods, to avoid a breaking change.

I'm not sure if it there is any use case for a long in Decrement/Increment, so for now I didn't touch those.

from algoliasearch-client-csharp.

TomKlotzPro avatar TomKlotzPro commented on September 22, 2024

Thank you 🙇
I'll take a look today, nice job 👍

from algoliasearch-client-csharp.

sbellone avatar sbellone commented on September 22, 2024

Hi @hognevevle, thanks for the PR!

but it still prevents me from using .ToUnixTimeMilliseconds() which I would prefer

Just note that you can still build the operation yourself:

var record = new Record
{
    ObjectID = "myID",
    Count = new PartialUpdateOperation<long>
    {
        Operation = PartialUpdateOperationType.IncrementFrom,
        Value = (long)2
    },
};

But it's indeed handy to have it built-in 👍

from algoliasearch-client-csharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.