Comments (6)
Merged through #799, thanks again! 👍
from algoliasearch-client-csharp.
Hey @hognevevle,
Thanks for this feedback, I'll check with the engine-team if we can send a long.
I'll keep you updated about this.
from algoliasearch-client-csharp.
Hello @hognevevle,
I've checked with the engine team, and indeed, this should be a long! Do you want to open the PR to update the code ? I could do it but next week. 😞
However, I'm preparing a new minor release for next week, so it fits really well.
from algoliasearch-client-csharp.
Opened #777 . Decided to add overloads for IncrementFrom
/IncrementSet
instead of updating the existing methods, to avoid a breaking change.
I'm not sure if it there is any use case for a long
in Decrement
/Increment
, so for now I didn't touch those.
from algoliasearch-client-csharp.
Thank you 🙇
I'll take a look today, nice job 👍
from algoliasearch-client-csharp.
Hi @hognevevle, thanks for the PR!
but it still prevents me from using .ToUnixTimeMilliseconds() which I would prefer
Just note that you can still build the operation yourself:
var record = new Record
{
ObjectID = "myID",
Count = new PartialUpdateOperation<long>
{
Operation = PartialUpdateOperationType.IncrementFrom,
Value = (long)2
},
};
But it's indeed handy to have it built-in 👍
from algoliasearch-client-csharp.
Related Issues (20)
- Add a `filters` field in the query rules condition
- Need a way to add custom logging for the Http Request and Response HOT 2
- Calling Index.Delete().Wait() throws null reference exception. HOT 2
- (feat): Custom Dictionaries
- feat(virtual indices): Virtual indices related parameters
- RetryStrategy failed to connect to Algolia. Reason: Error while copying content to a stream. HOT 12
- Update Contributing guide DX-1783
- Rename Recommendation API to Personalization API
- Recommend client HOT 1
- Dependency Dashboard
- Ensure compatibility with .NET 6 HOT 1
- PartialUpdateObject not working when using a JObject payload / the parser doesn't unwrap the objectId correctly HOT 5
- Buffering HOT 1
- Consider returning and depending on interfaces in `ISearchClient` HOT 5
- GetObjectAsync has wrong comma encoded in URL when attributesToRetrieve HOT 1
- Hard to find documentation about highlighting. HOT 3
- [🔔 Announcement 🔔] New client - looking for early feedback! HOT 9
- Use other type than string for ObjectID HOT 1
- Bad changelog from NuGet HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from algoliasearch-client-csharp.