Comments (6)
Hello, I have a question. In the case where we have code in the
graphar
namespace but not in any nested namespace (like theStatus
class functions), should we still modify the namespace to use the C++17 nested namespace syntax? From my understanding, using the new syntax wouldn't reduce the nesting in this case. Could you please clarify this? Thank you.
Hi, I think you could separate the code and re-org them using the new style, like:
namespace graphar::util {
...
}
namespace graphar {
...
}
from graphar.
Hello, I'm interested in taking on this issue. I understand it involves implementing cleaner code. Could you please assign it to me? Thank you.
Sure, the issue has been assigned to you. Thank you for your interest, and we are looking forward to your contribution.
from graphar.
Hello, I'm interested in taking on this issue. I understand it involves implementing cleaner code. Could you please assign it to me? Thank you.
from graphar.
Hello, I have a question. In the case where we have code in the graphar
namespace but not in any nested namespace (like the Status
class functions), should we still modify the namespace to use the C++17 nested namespace syntax? From my understanding, using the new syntax wouldn't reduce the nesting in this case. Could you please clarify this? Thank you.
from graphar.
Can this issue be closed?
from graphar.
yes, thanks for @ywh555hhh 's work, the issue has been resolved.
from graphar.
Related Issues (20)
- OSPP24 Idea: Implement ETL CLI Tools for GraphAr HOT 2
- Tracking issue of GraphAr first Apache release HOT 2
- feat(java): rename the java package to 'graphar-java' HOT 2
- feat(java): Add aggregator POM for java and spark library to manage the dependency
- feat(c++): rename the header folder and library name from `gar` to `graphar`
- [java-info] Merge java-info code into main by components step by step HOT 3
- fix(license): fix the LICENSE and NOTICE according to ASF requirement
- feat(spark): Add an example to generate ldbc sample data from csv to graphar
- fix(infra): Fix the invalid dev container image HOT 3
- [Spark] Move datasources under org.apache.spark package HOT 8
- Improve the building process and contributing document for developer to easily building the libraries from scratch HOT 8
- feat(c++): deprecate the `building arrow dependency from source` building strategy HOT 1
- [Doc] [Improvement] prepare a more beginner-friendly developer documentation for the C++ library HOT 1
- [Feat][CI] Enable markdownlint and typos in Graphar Doc workflow HOT 3
- [Bug][docker] Missing pre-commit/install-hook.sh Script During Remote Containers Post-Creation
- [Bug][C++][Test][Docker] Test Failure: Subprocess Terminated Due to Missing `/etc/localtime` Time Zone File in dev container HOT 1
- feat(c++): Update the Catch2 dependency to v3 and remove the Catch2 submodule
- feat(CI): Remove the testing submodule and use a specified environment variable to indicate the testing data directory
- Fail to build v6d HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphar.