Japanese support about neatvi

[cjwagenius]

Does your terminal font face have Japanese characters? Can you type them at the command line?

[kyx0r]

Hello, for right now what I am trying to do is really simple, It should not really matter if I can type the characters at command line at the moment, and I have the fonts supported by my terminal 100% sure. So for example, if I remove these two lines of code here this is the output I get in neatvi.

[kyx0r]

But understand this, while the output is rendered correctly by the terminal, vi does not interpret their length correctly, so moving around, deleting characters, etc does not work correctly.

[kyx0r]

This should be valid UTF-8. Here it is, use it for testing
日本国
平仮名
標準語

[aligrudi]

MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Kyryl <[email protected]> wrote:

This should be valid UTF-8. Here it is, use it for testing 日本国 平仮名 標準語

Please try the following patch. Thanks, Ali diff --git a/ren.c b/ren.c index 3195598..a294c07 100644 --- a/ren.c +++ b/ren.c @@ -154,7 +154,7 @@ int ren_cwid(char *s, int pos) for (i = 0; !conf_placeholder(i, &src, &dst, &wid); i++) if (uc_code(src) == uc_code(s)) return wid; - return 1; + return uc_wid(s); } char *ren_translate(char *s, char *ln) diff --git a/uc.c b/uc.c index 4172003..55fec26 100644 --- a/uc.c +++ b/uc.c @@ -595,7 +595,7 @@ int uc_isbell(char *s) if (c == ' ' || c == '\t' || c == '\n' || (c <= 0x7f && isprint(c))) return 0; c = uc_code(s); - return uc_isdw(c) || uc_iszw(c) || find(c, bchars, LEN(bchars)); + return uc_iszw(c) || find(c, bchars, LEN(bchars)); } /* nonprintable characters */

[kyx0r]

Thank you. The patch does exactly what I expect. Are there any false positives to this, otherwise I don't see any reason to not patch this in into the base version of neatvi.

[aligrudi]

Kyryl <[email protected]> wrote:

Thank you. The patch does exactly what I expect. Are there any false positives to this, otherwise I don't see any reason to not patch this in into the base version of neatvi.

Thanks for testing. Applied. Ali