GithubHelp home page GithubHelp logo

Comments (5)

Alir3z4 avatar Alir3z4 commented on July 26, 2024

It's a Python 3 compatibility issue.
I'll look into it later, meanwhile feel free to patch.

I mark this as a bug.

from html2text.

djr7C4 avatar djr7C4 commented on July 26, 2024

This problem also occurs when running html2text as the mu4e-html2text command in mu4e in Emacs and is caused by the fact that str objects do not have decode methods.

Replacing

data = data.decode(encoding)

on line 1083 of init.py with

if hasattr(data, "decode"):
    data = data.decode(encoding)

seems to fix it.

from html2text.

willemw12 avatar willemw12 commented on July 26, 2024

File objects in Python 3 are not binary by default. See https://docs.python.org/3/library/sys.html#sys.stdin. The fix, at least for Python 3, in file html2text/init.py is:

    else:
    #data = sys.stdin.read()
    data = sys.stdin.buffer.read()

Note: the other input/file objects do return bytes (urllib.urlopen() and open(file_, 'rb')).

Adding additional shell script tests would be useful, similar to:

  1. "echo '

    hi

    ' | html2text"
  2. html2text file
  3. html2text url

from html2text.

Alir3z4 avatar Alir3z4 commented on July 26, 2024

Please have a look at pull request #46 it passes the test suite at travis as well: https://travis-ci.org/Alir3z4/html2text/builds/42863577

Lemme know if you have any suggestion for improvement, I'll merge by end of the week and issue new release.

from html2text.

Alir3z4 avatar Alir3z4 commented on July 26, 2024

The fix for this bug #46 has been merged and included in version 2014.12.5:

Changes:
https://github.com/Alir3z4/html2text/releases/tag/2014.12.5

Available on PyPi now:
https://pypi.python.org/pypi/html2text/2014.12.5

Thanks for your awesome contribution.

from html2text.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.