Malformed output of links about html2text

[theSage21]

Just started using this. working on it.

[theSage21]

@Alir3z4 @barsch Am I right in assuming that

<a href="http://www.test.com">http://www.test.com</a>

should give me
[http://www.test.com](http://www.test.com)

I am a little new to markdown.

[Alir3z4]

@theSage21 That is correct, <a href="http://www.test.com">http://www.test.com</a> should give [http://www.test.com](http://www.test.com)

[theSage21]

@Alir3z4 Also. Should I add some documentation? As a non English speaker this repo was very confusing to me initially. Docs would have helped.

[Alir3z4]

@theSage21 Sure, that would be great.
You can have #39 this one as well if you like.

[theSage21]

@Alir3z4 Al right. I will try to fix this then #39

[Alir3z4]

Awesome ;)

On Sun, May 31, 2015 at 1:31 PM, arjoonn sharma [email protected]
wrote:

@Alir3z4 https://github.com/Alir3z4 Al right. I will try to fix this
then #39 #39

—
Reply to this email directly or view it on GitHub
#61 (comment).

[theSage21]

This bug This is triggered whenever the text matches the url and it is an absolute url.
It seems this is deliberate. Lines 698 to 701

Removing that condition fixes it. I am not sure if this is a requirement of markdown or not. @Alir3z4 @barsch . Is this a bug or feature? Daring Fireball is silent on these types of links and nobody on IRC seems to know.

[theSage21]

@Alir3z4 @barsch This is not a bug. The test/url-escaping.md specifically tests this functionality. I recommend that this issue be closed.

[barsch]

Is <http://www.test.com> a valid Markdown syntax for an inline link?

http://daringfireball.net/projects/markdown/syntax#link states:

Markdown supports two style of links: inline and reference.
In both styles, the link text is delimited by [square brackets].

However there is an example further down using angle brackets for a referenced link:

[id]: <http://example.com/>  "Optional Title Here"

[theSage21]

@barsch I am not sure about the proper format. Daring Fireball says nothing about automatic links.
In the tests directory the url-escaping.md file has
* Use automatic links like <http://example.com/> when the URL is the label
Since this type of conversion has been specifically tested I think it was intended to be a feature.

Also notice that
<a href="http://www.test.com">http://www.test.com</a>
<a href="http://www.test.com/">http://www.test.com/</a>
both translate validly to:
<http://www.test.com>
<http://www.test.com/>

Hence whenever the href is absolute and is the same as the text the format of <http://text> is used.

[theSage21]

@barsch @Alir3z4 How about we add a config parameter which is by default left to use automatic links but can be set to translate these types of links to normal Markdown? I think that is a good idea since people can configure as they wish then and people already depending on this module can go on undisturbed.

[Alir3z4]

@theSage21 I like the idea of having config for those kind of link. is --reference-link option does it ?

[theSage21]

@Alir3z4 Sorry, just noticed it. Yes --reference-link does it.

[Alir3z4]

@theSage21 So this issue can be closed if we consider --reference-link as the solution ?

[theSage21]

@Alir3z4 Yes. The issue can be closed. Automatic links are now optional via the --reference-link option.