Comments (3)
I'd like to suggest some reasons why caching shouldn't be a part of the workflows in this repo and that, instead, individual repos be encouraged to include caching if they'd find it helpful.
Adding caching adds a new way that a workflow can break. Granted, most of my experience with dependency caching and CI workflows come from our private client repositories. But in that experience, when a workflow breaks because of something related to cache, it's usually not easy to figure out why, not easy to replicate the problem locally, and not related to the changes in the Pull Request. Implementing the catch-all solution of "clear the cache and try again" is, arguably, also a barrier for someone who doesn't know how to do that (or doesn't have the permission to). All of these conditions make the problem frustrating for someone who is put in a position where they don't have control over why their PR appears to be failing automated tests, especially if they haven't seen Composer caching before.
So, my sense is that omitting caching generally makes it easier for any developer to simulate the behavior of the workflow, which in turn makes it easier to contribute.
Even our busiest repos aren't getting a ton of PRs every month — at least not yet. Are we going to be saving that much time by caching in exchange for its added complexity? Maybe, but I'm not sure.
from .github.
@dlh01 totally agree. it's probably a small amount of time saved. it could also be something optional for the workflows that people can opt into (versus on by default).
from .github.
Making it available but opt-in would be a great balance!
from .github.
Related Issues (20)
- Add workflow for PHPStan
- New "Update Changelog" Workflow
- Naming reusable workflows HOT 1
- Make file changes verbose in "push to -built branch" job in "Built Branch" work flow
- [BUG]: Issue template titles are difficult to follow HOT 3
- "push to -built branch": is `.deployignore` required?
- Add persistent object cache to phpunit tests HOT 1
- "push to -built tags" actually remove `.gitignore` files
- Upgrade default version of PHP to 8.1
- Add Memcache Support
- Apply Labels Universally HOT 3
- Review `--generate-notes` usage HOT 2
- Update CONTRIBUTING.md to include more details on how to contribute
- Setup domain for GitHub Pages HOT 1
- Upgrading to actions/cache v4 breaks tests HOT 1
- Allow control over the version of MySQL Used with php-tests.yml
- Allow testing against a rolling number of versions (last 3 versions of WordPress)
- PHP Tests with MySQL Workflow: support setting up core test suite
- Allow building of project during testing
- Add ability to add caution options and groups to theme builder HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from .github.