confusing type in add_attachment method about allure-ruby-commons

[smecsia]

You're right, this seems to be mistake. It should be File.basename file. Could you send a PR?

[sharmarahul]

@smecsia @xiaoxinghu I guess the PR for the issue above has already been merged followed by mine in which I added parentheses to fix the syntax error, however, I now have no screenshots in my report. I get the following error:
NoMethodError: private method debug' called for nil:NilClass
occurred at /Users/sharmrw1/.rvm/gems/ruby-2.2.0/gems/allure-ruby-adaptor-api-0.6.8/lib/allure-ruby-adaptor-api/builder.rb:87:in add_attachment'

[sharmarahul]

The reason there are no attachments is because I am using the output dir to save my screenshots so it gets wiped out using the clean_dir config. With file now using File.basename, it doesn't know where the screenshot is anymore

[sharmarahul]

@smecsia I have sent you a PR to fix the above error. @logger should be LOGGER

[sharmarahul]

@smecsia I should have bumped up the version in my PR as well. Would you mind bumping up version for the @logger fix and updating dependency in allure-rspec? I can send another PR if you'd like!

[smecsia]

@sharmarahul I've pushed 0.7.4 to rubygems.