GithubHelp home page GithubHelp logo

Retry callback bug about dio_retry HOT 9 OPEN

aloisdeniel avatar aloisdeniel commented on May 23, 2024 2
Retry callback bug

from dio_retry.

Comments (9)

aloisdeniel avatar aloisdeniel commented on May 23, 2024

Thank you, I will fix that. :)

from dio_retry.

rodion-m avatar rodion-m commented on May 23, 2024

Thank you, I will fix that. :)

You are welcome and thank you for a useful module!

from dio_retry.

carmas123 avatar carmas123 commented on May 23, 2024

Sorry but when you release this fix on Pub?

from dio_retry.

jatin-kataria-sc avatar jatin-kataria-sc commented on May 23, 2024

var shouldRetry = extra.retries > 0 && await options.retryEvaluator(err);

where to change this

from dio_retry.

jatin-kataria-sc avatar jatin-kataria-sc commented on May 23, 2024

i have tried but the function api is nhi been
retries

from dio_retry.

jatin-kataria-sc avatar jatin-kataria-sc commented on May 23, 2024

on 404 it only retries only once

from dio_retry.

azimuthdeveloper avatar azimuthdeveloper commented on May 23, 2024

I fixed this in my branch by manually applying the PR. Here's how to use it in your project. You can use my patched version by adding this to your pubspec.yaml instead of the existing dio_retry package.

  dio_retry:
    git:
      url: https://github.com/lewcianci/dio_retry.git
      path: dio_retry

from dio_retry.

azimuthdeveloper avatar azimuthdeveloper commented on May 23, 2024

I also removed the dependency on logger in my fork. I prefer a more generic callback.

EDIT: I bit the bullet and published it to pub dev, you can grab it here if you want: https://pub.dev/packages/dio_retry_fixed

from dio_retry.

scaraux avatar scaraux commented on May 23, 2024

@aloisdeniel any idea when you can get this fixed? Would be awesome to have it on prod

from dio_retry.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.