Use of aria-live inconsistent across www.gov.uk search results about finder-frontend

[selfthinker]

I looked at all the linked pages but can only see one value (aria-live="assertive"). Has this been fixed? Only https://www.gov.uk/government/statistics doesn't have any aria-live at all. (At least I couldn't find it.)

But having briefly looked at the implementation now, I would improve two other things:

1. What is wrapped in the div with the aria-live includes the number of results (in an h2), the facet tags and on some pages the "get email alerts" and "subscribe to feed" links. At least those links should not be announced to screen readers because they don’t change. (Actually, I assume the URL changes, but that won't be apparent to anyone, including screen reader users.) The facet tags can be up for debate if it makes sense for them to be announced, but I would suggest to only wrap the h2 (or add the aria-live directly to the h2).

2. After filtering at least once, the h2 gets nested in another h2. That is invalid HTML.

[andysellick]

@kr8n3r yeah I think I remember spotting that and fixing it.

[kr8n3r]

@injms or @andysellick
I have point 2 from ⬆️ as a ticket but it seems that it has been fixed.
can either of you confirm or alternatively show how to replicate (in case i'm missing something)?

edit: possibly fixed here https://github.com/alphagov/finder-frontend/pull/1066/files#diff-32432de741de8d01ce8959f91547b1c5

[kr8n3r]

thanks Andy

[andysellick]

@tombye I believe we replaced all of the finders that this ticket is talking about (originally from whitehall, now rebuilt in finder-frontend) and the aria issue should have now been fixed. Can you confirm if this is the case?

[tombye]

Looks like all of these now share the same implementation and the issues @selfthinker raised are now fixed so I'm marking this as resolved. Nice work! 👍