GithubHelp home page GithubHelp logo

Comments (13)

mseveritt avatar mseveritt commented on July 24, 2024 1

I created a PR. Feel free to change it.

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024 1

Great, thanks for your help!
I will modify some of them, especially the one for which i think I should create a new icon:

  • bulky
  • hypnotix
  • celluloid
  • pdfarranger
  • cs-background
  • cs-tablet

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

I will work on it!
Thanks for reporting this 😉

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

Thanks for your feedback. I think most of the icons are already there, only the links are needed.

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

Missing icons: (possible origin and linked cs-*.svg)
preferences-desktop-wallpaper.svg -> cs-backgrounds.svg
applications-multimedia.svg -> cs-sound.svg (improvement?)
? -> cs-tablet.svg
redshift.svg

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

Thanks!

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

No problem, I am happy to learn and contribute. There are some more to come.

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

I think I am finished with mapping existing icons to missing ones (new PR is created). The only few ones left are mentioned above. They may have to be created as I did not find a match.

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

All should be good now,
I will test it a little bit on cinnamon during the week, and bring some changes if needed 🛩ī¸

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

Thanks a lot!
Maybe it is just for me, but somehow cs-tablet.svg does not work. The rest works like a charm.
grafik
grafik

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

I got it: The icon for cs-tablet.svg needs to be tablet.svg in devices in order to work. I also updated drive-removable-media.svg in devices which impacts volman in XFCE. PR is created.

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

On second thought, this was not a good idea for the consistency of devices-icons. Sorry.
All that is necessary is your cs-tablet.svg and org.xfce.volman.svg from apps present in devices and their devices-links removed.
Revised PR is on its way.

from nordzy-icon.

mseveritt avatar mseveritt commented on July 24, 2024

Done.

from nordzy-icon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.