GithubHelp home page GithubHelp logo

Comments (11)

MolassesLover avatar MolassesLover commented on July 24, 2024 2

It looks perfect! Thank you so much, again.

Screenshot from 2022-09-25 14-03-31

Please let me know if any of my pull requests have the wrong backdrop, I'd fix it in a heartbeat.

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024 1

Thanks for noticing this @MolassesLover ! 👍
There is indeed some inconsistency there, but that is not a big deal! I will have a look to make a standardise backdrop shadows, then I will write a script to find and replace them all at once without having to do it manually 😉

Blender and UPBGE backdrops are more noticeable because the offset and darkness of the backdrop shadows are more important compare to the other.

It is also good to know that in fact merged and separate are usually the same, when optimizing the icons, Inkscape will just group some shape such as the background and the backdrop shadow to spare some text and have lighter .svg. They can be separated with ctrl + g when selected

from nordzy-icon.

MolassesLover avatar MolassesLover commented on July 24, 2024

My bad, I'll use the outline view now, and keep an eye on the objects/layers. Also, how do you plan on making the script?

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

Should be fixed now !! 👍 I do not think I missed any of the icons nor made mistake, but we will see with time and uses.
For my script, I used the 'sed' command with a regex to select only the shadows of most of the icons (something like 260 on 300) and replace it with the SVG code of the new shadow. Then I modified the other 40 manually 😛

This is basically what I came up with:

#!/bin/bash
new_shadow='<rect transform="matrix(.99138 0 0 1 .072989 .0019055)" x=".79375" y=".90545" width="15.346" height="15.346" rx="3.0526" ry="3.0526" fill="#2e3440" filter="url(#filter1178)" opacity=".45" stroke-width="1.2489" style="mix-blend-mode:normal"\/>'

for icon in $HOME/github/Nordzy-icon/src/apps/scalable/*; do
	sed -i "s/<rect.*width=\"15.346\" height=\"15.346\" rx=\"3.0526\" ry=\"3.0526\" fill=\"#2e3440\".*\/>$/${new_shadow}/g" ${icon}
done

from nordzy-icon.

MolassesLover avatar MolassesLover commented on July 24, 2024

That's amazing work, thank you so much!

It's fixed but now the issue arises that all of the backdrop shadows are #2e3440. This matches the Nord colour scheme, of course, but ends up making the theme really hard to read with Nordic GTK.

Screenshot from 2022-09-14 13-52-34-1

Do you think the shadows should be black? Or should they be kept as they are now?

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

I will try putting them in a classic black to see how it looks 😉

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

I created a new branch where i modified all the backdrop shadows with a full black. Could you try this dev branch ? My desktop does not have a full background with nord color so I don't have the issue... 😛 Thanks

from nordzy-icon.

MolassesLover avatar MolassesLover commented on July 24, 2024

It works fine! Though, the black seems to be at 45%, which, in my opinion, I find a bit too strong. I would prefer it if you set it to 15%, which is what I used (I think).

Screenshot from 2022-09-22 21-11-23

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

That is better, but you are right, the shadow is too strong in opacity. I will try 15% as you suggest!

from nordzy-icon.

MolassesLover avatar MolassesLover commented on July 24, 2024

Awesome, thank you so much!

from nordzy-icon.

alvatip avatar alvatip commented on July 24, 2024

Still in the black_shadows branch, I updated the opacity to 15%. Could you give it a try ? Thanks

from nordzy-icon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.