GithubHelp home page GithubHelp logo

Comments (19)

AM1CODES avatar AM1CODES commented on August 18, 2024 1

can I have this assigned?

Yes its assigned to you. You can start working on it.

from poke-dex.

AM1CODES avatar AM1CODES commented on August 18, 2024 1

Yes i will label it as well

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

can I have this assigned?

from poke-dex.

AM1CODES avatar AM1CODES commented on August 18, 2024

Thank you for contributing! The website is responsive now. Just one thing, the up arrow at the bottom of the page is a little misalligned, so if you can bring it to center again, it would be great and just the like - "Show us your favourite pokemons" could be brought a little bit up in the mobile version so that the down arrow can fit in better. Thank you.

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

wait what happened wasn't there a comment about the header text still being misaligned vertically?

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

can you send a screenshot of what you just described?

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

did you clear the cache? I'm gonna try pulling it up on my laptop to see if anything is different

from poke-dex.

AM1CODES avatar AM1CODES commented on August 18, 2024

Yes yes that part is cleared, it was an error on my part. Just the above mentioned issue is remaining rn.

from poke-dex.

AM1CODES avatar AM1CODES commented on August 18, 2024

Screenshot_2020-10-10-09-00-58-348_com android chrome
Screenshot_2020-10-10-09-00-51-365_com android chrome
i was talking about these two things, if the down button could be shifted a little up.

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

ahh I see. I can re create the bug on chrome. It should be fixable

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

@AM1CODES could you please mark that merged pull request as hacktoberfest-accepted so it counts towards the 4/4 goal?

from poke-dex.

AM1CODES avatar AM1CODES commented on August 18, 2024

ahh I see. I can re create the bug on chrome. It should be fixable

Okay. Try and work on it and see what changes you can make to it. Thank you.

from poke-dex.

srishtij2000 avatar srishtij2000 commented on August 18, 2024

Can I work on this issue?

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

@srishtij2000 I want to share a little thing I noticed when first examining the issue: The width of the header would change after the page finished loading some element which takes several seconds but not longer than a minute.

from poke-dex.

srishtij2000 avatar srishtij2000 commented on August 18, 2024

So are you going to assign this issue or should I just submit the PR?

from poke-dex.

FireLemons avatar FireLemons commented on August 18, 2024

yeah just submit a pr

from poke-dex.

srishtij2000 avatar srishtij2000 commented on August 18, 2024

Okay okay

from poke-dex.

srishtij2000 avatar srishtij2000 commented on August 18, 2024

I have issued a PR so kindly review it

from poke-dex.

AM1CODES avatar AM1CODES commented on August 18, 2024

This issue has been solved. Thank you for contributing @srishtij2000 @FireLemons

from poke-dex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.