Comments (19)
can I have this assigned?
Yes its assigned to you. You can start working on it.
from poke-dex.
Yes i will label it as well
from poke-dex.
can I have this assigned?
from poke-dex.
Thank you for contributing! The website is responsive now. Just one thing, the up arrow at the bottom of the page is a little misalligned, so if you can bring it to center again, it would be great and just the like - "Show us your favourite pokemons" could be brought a little bit up in the mobile version so that the down arrow can fit in better. Thank you.
from poke-dex.
wait what happened wasn't there a comment about the header text still being misaligned vertically?
from poke-dex.
can you send a screenshot of what you just described?
from poke-dex.
did you clear the cache? I'm gonna try pulling it up on my laptop to see if anything is different
from poke-dex.
Yes yes that part is cleared, it was an error on my part. Just the above mentioned issue is remaining rn.
from poke-dex.
i was talking about these two things, if the down button could be shifted a little up.
from poke-dex.
ahh I see. I can re create the bug on chrome. It should be fixable
from poke-dex.
@AM1CODES could you please mark that merged pull request as hacktoberfest-accepted
so it counts towards the 4/4 goal?
from poke-dex.
ahh I see. I can re create the bug on chrome. It should be fixable
Okay. Try and work on it and see what changes you can make to it. Thank you.
from poke-dex.
Can I work on this issue?
from poke-dex.
@srishtij2000 I want to share a little thing I noticed when first examining the issue: The width of the header would change after the page finished loading some element which takes several seconds but not longer than a minute.
from poke-dex.
So are you going to assign this issue or should I just submit the PR?
from poke-dex.
yeah just submit a pr
from poke-dex.
Okay okay
from poke-dex.
I have issued a PR so kindly review it
from poke-dex.
This issue has been solved. Thank you for contributing @srishtij2000 @FireLemons
from poke-dex.
Related Issues (20)
- Fix broken images HOT 1
- Add scale animation. HOT 1
- Dead links used as images
- Image rendering issues in many pokemons HOT 1
- Add a search engine by the name of each pokemon HOT 1
- Add some more pokemon details HOT 2
- I want to make it mobile responsive
- Ability to sort cards HOT 7
- Ability to toggle the theme of the website HOT 1
- Drapion image is not rendering HOT 2
- Could insert thumbnail of pokemon
- there are 2 entries to pokemon Gible HOT 8
- image extension issues (jpg) HOT 2
- Add Pagination HOT 1
- Creating New Designs for Pokedex HOT 10
- idea: add page for type chart HOT 2
- Updating the Poke-card design
- New Pokémon, More Fun HOT 1
- Adding search and filter option HOT 1
- Description Hover Effect HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poke-dex.