GithubHelp home page GithubHelp logo

Comments (1)

amannn avatar amannn commented on June 3, 2024 1

To address the two lines reported by your linter:

  1. Narrowing with .includes is something that's unfortunately not supported in TypeScript (microsoft/TypeScript#36275). If you want to comply with that lint rule, you can use one of the proposed workarounds in that thread or similar ones.
  2. The dynamic import can't really be typed in a meaningful way here, but if you like, you can add your own runtime validation on top. However, next-intl includes a lot of error-handling capabilities that help with catching errors in messages.

Generally, the code presented works fine without any issues. If you choose to enable lint rules that find theoretical issues in code, I'm afraid it's your job to find patterns that align with your rules.

Sorry for pushing a bit back here, but next-intl has to operate in the spectrum of integrating deeply with tools like React and Next.js, while also working well with TypeScript. The code that's reported by your linter here doesn't have any issues, therefore I'd question if you really want those rules or if you want to disable them here. next-intl tries to integrate with TypeScript in any way where actual issues can be discovered (e.g. a type-safe t function), but the snippet you've pasted above just isn't an issue.

I'm closing this issue therefore, I hope you can understand.

from next-intl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.