Comments (6)
I'm fine with passing along stats. But the stats from the initial walk could very well be outdated?
from sane.
Yes, by definition they should be outdated (since we have a new file system event). As long as we update the local hash with the latest each time (which my diff did not do), it should always be providing the most recent stat prior to the current event and the newest one (from the current event).
Does that make sense?
from sane.
yeah that makes sense. PR welcome :)
from sane.
I like this, and IMHO that diff doesn't look terrible at all.
from sane.
In 556ad4d I pass in the current stat. Passing the old stat (and keeping it up-to-date) seemed a bit trickier but I'm open to a diff with tests :)
from sane.
@rwjblue can we close this?
from sane.
Related Issues (20)
- add utilize to "autodetect" best watcher.
- bump engine support to node version that are supported.
- bump engine support to node version that are supported.
- Update exec-sh dependency HOT 5
- Invalid tag name "[email protected]": Tags may not have any characters that encodeURIComponent encodes. HOT 1
- Why the [email protected] don't support node 9.*.* HOT 2
- Watching file recursively HOT 6
- Bundle size
- Renaming directories with childs on windows locked HOT 1
- Watchman does not understand micromatch globs HOT 9
- Multiple package locks HOT 1
- Support for more Node.js versions HOT 1
- Is there support for killing the currently running process? HOT 1
- Consider dropping `node@6`. HOT 2
- upgrade to v ^4.x.x of micromatch to avoid npm vulnerability 1490 in kind-of
- OS Command Injection in execa (execa@^1.0.0) HOT 4
- High severity vulnerability detected in sane dependencies HOT 1
- High Vulnerability is found in the dependency. HOT 1
- EMFILE: too many open files, watch HOT 1
- minimist <= 1.2.5 have an vulnerability
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sane.