GithubHelp home page GithubHelp logo

Comments (6)

amasad avatar amasad commented on May 28, 2024

I'm fine with passing along stats. But the stats from the initial walk could very well be outdated?

from sane.

rwjblue avatar rwjblue commented on May 28, 2024

Yes, by definition they should be outdated (since we have a new file system event). As long as we update the local hash with the latest each time (which my diff did not do), it should always be providing the most recent stat prior to the current event and the newest one (from the current event).

Does that make sense?

from sane.

amasad avatar amasad commented on May 28, 2024

yeah that makes sense. PR welcome :)

from sane.

DavidSouther avatar DavidSouther commented on May 28, 2024

I like this, and IMHO that diff doesn't look terrible at all.

from sane.

amasad avatar amasad commented on May 28, 2024

In 556ad4d I pass in the current stat. Passing the old stat (and keeping it up-to-date) seemed a bit trickier but I'm open to a diff with tests :)

from sane.

stefanpenner avatar stefanpenner commented on May 28, 2024

@rwjblue can we close this?

from sane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.