node error: FSEventStreamStart: register_with_server about sane

[amasad]

I think you're running into this nodejs/node-v0.x-archive#5463. Sometimes restarting helps. Also maybe you're watching more directories than you have to. How many are you watching? Otherwise it's fixed in v0.11

[matthewmueller]

Yep that's what it is. I thought the glob would only watch those files, but it was watching all the dirs in node_modules, related to this: #23

Tradeoff I guess between the feature add/remove and watching a bunch of directories.

[matthewmueller]

Maybe you could conditionally watch directories (for the add and remove feature):

sane(root, glob)
  .watch('lib')
  .on('change', fn)
  .on('add', fn)

[amasad]

Tradeoff I guess between the feature add/remove and watching a bunch of directories.

That's part of it but another problem is that sane will need to understand globs in order to safely ignore directories that will not produce a matching path. Example:

var glob = 'a/*.js';
var directory = 'a';
var file = 'a/a.js';

minimatch(directory, glob); // false
minimatch(file, glob); // true

Is there an easy way to do that?
It seems that minimatch does expose internal methods maybe we could use to do a partial match. If you want to work on it, I'd love to help.

[amasad]

Also we can add a filter function to decide whether to watch a dir or not

[amasad]

Reopening this to try and figure ways around it. Although this is fixed in v0.12 it seems like it's still some time away

[amasad]

FYI 2d2b1a2 adds support for watchman which works really great on OS X and linux and doesn't suffer from this problem. I'd still want to find some time to make sane have better understanding of globs to lessen the severity of this bug

[matthewmueller]

@amasad sweet!

question: why not just make watchman the default, does it not do everything the default does?

[amasad]

No windows support :/ But they're working on it but won't come until next year.
It also requires people to go install a native program which I feel most people wouldn't want to do when starting to use sane. However, all the APIs are the same (they run the same test suite) so it should be easy for clients of sane to programmatically select the mode (and programmatically install watchman as well) depending on the OS and node version. I wrote a section in the readme to help people decide https://github.com/amasad/sane#how-to-choose-a-mode

[matthewmueller]

Ahh gotcha. So fb-watchmen is just a client into the C program? Would it make sense / do you know of anyone already node-gyp'ing the C program?

I wrote a section in the readme to help people decide https://github.com/amasad/sane#how-to-choose-a-mode

Oops I missed that haha, thanks

[amasad]

So fb-watchmen is just a client into the C program?

yes

Would it make sense / do you know of anyone already node-gyp'ing the C program?

I don't think anyone is working on it. We just added the "fb-watchman" client. Although it's designed to be a background daemon, I can't see why it wouldn't make sense to make it into an addont. If you're interested in that, open an issue https://github.com/facebook/watchman the folks running the project are very helpful in these things.

[stefanpenner]

I believe we can close this now. v0.12 is EOL, and watchman support is baked in