GithubHelp home page GithubHelp logo

No way to watch dotfiles about sane HOT 8 CLOSED

amasad avatar amasad commented on May 28, 2024
No way to watch dotfiles

from sane.

Comments (8)

amasad avatar amasad commented on May 28, 2024

I think making it an option is best. Patch welcome :)

from sane.

callumlocke avatar callumlocke commented on May 28, 2024

Ok I'll do a patch to allow passing options for minimatch.

You want the dotfiles option to be off by default? Just curious, why?

from sane.

amasad avatar amasad commented on May 28, 2024

The first thing that comes to mind is the annoying .DS_Store files in mac which generate a lot of noise

from sane.

callumlocke avatar callumlocke commented on May 28, 2024

OK cool.

The simplest way to do this is probably to accept a new option, e.g. globOptions, globOpts, minimatchOpts, or something. Do you have a preference?

Or you could allow the existing globs option to be provided as an object, in which case it would be used as minimatch options (and the pattern property of that object would be used for globs).

Let me know which approach you prefer and I'll PR.

from sane.

amasad avatar amasad commented on May 28, 2024

why not just a toplevel dot: true option?

from sane.

callumlocke avatar callumlocke commented on May 28, 2024

because there are a bunch more options
https://github.com/isaacs/minimatch#options

personally I'd be happy with just dot:true, that's all I need, but I imagine people might want other ones?

from sane.

amasad avatar amasad commented on May 28, 2024

until they ask for it I think we're fine ;)

from sane.

callumlocke avatar callumlocke commented on May 28, 2024

closing as this has been merged

from sane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.