Excluding node_modules in watcher about sane

[amasad]

Have you tried the globs option?

On Sun, Aug 21, 2016, 2:20 AM Guy Bedford [email protected] wrote:

If running the Node native watcher on a folder that contains a large
node_modules directory, we want the ability to ignore this folder.

Is there any way in this project (or with the Node native watcher for that
matter), to handle use cases like this?

See jspm/jspm-cli#1999 jspm/jspm-cli#1999 for
more info.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#72, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj2_hYFYCQ0ulG8gN8Y6-e5QvcROcmkks5qiBhAgaJpZM4JpQni
.

[guybedford]

See the discussion previously at jspm/jspm-cli#1775 (comment).

The issue is that because we know the specific module tree, we do know exactly which individual files to watch.

I'm wondering if it's worth just falling back to a custom fs.watch call here on the specific directories we know we need to listen to, as we don't need recursion actually.

[amasad]

Yeah that might make sense. We can also have a predicate function that gets called on directories and if returns false it will skip watching that dir or any of it's descendants. I don't have the time to do any work on this. So let me know what works for you and patches welcome