Doesn't support property setters about retype

[gaborbernat]

Feel free to put in a PR to fix this and we'll review it 👍

[Findus23]

Hi,

Many thanks for the quick response!

I will look into if I can fix it easy and create a PR, but I won't promise too much as I am possibly not familiar with python enough for this.

Honestly, this isn't even such an important feature, it would just be nice to have for my use case and I wanted to create an issue so that future users can immediately that this doesn't work yet instead of trying it out needlessly.

[Findus23]

Definitely not a proper solution and therefore I won't create a PR, but this works around the issue:

Patch:

diff --git a/src/retype/__init__.py b/src/retype/__init__.py
index 927d64f..adaad2a 100644
--- a/src/retype/__init__.py
+++ b/src/retype/__init__.py
@@ -238,6 +238,9 @@ def _r_functiondef(fun, node, flags):
         and node.parent.type == syms.classdef
         and "staticmethod" not in pyi_method_decorators
     )
+    if len(pyi_decorators) > 0 and ".setter" in pyi_decorators[0]:
+        print("skip setter")
+        return []
     args, returns = get_function_signature(fun, is_method=is_method)
     for child in flatten_some(node.children):
         decorators = None

(this is the diff of the full solution: https://github.com/ambv/retype/compare/master...Findus23:skip-setters?expand=1)
Output:

from typing import Any
class Testclass:
    value: Any = None

    @property
    def someprop(self) -> Any:
        return self.value

    @someprop.setter
    def someprop(self, value):
        self.value = value

And by adding a similar check for overload one can also work around #20

[gaborbernat]

This project is being retired and archived, so we'll no longer address this.