Comments (4)
Please write more details about your issue. or write an example so that I understand what you mean.
Thank you
from httpclienttocurlgenerator.
Instead of using header.Value?.FirstOrDefault()
on the following lines, use string.Join("; ", header.Value)
. Header values can have more than one value, e.q. Cookie
, hence the type of HttpHeaders:
- https://github.com/amingolmahalle/HttpClientToCurlGenerator/blob/3fd81a431bae87548fd86d91d49ecbe58d99c817/src/HttpClientToCurl/Builder.cs#L106C22-L106C22
- https://github.com/amingolmahalle/HttpClientToCurlGenerator/blob/3fd81a431bae87548fd86d91d49ecbe58d99c817/src/HttpClientToCurl/Builder.cs#L121C61-L121C67
- https://github.com/amingolmahalle/HttpClientToCurlGenerator/blob/3fd81a431bae87548fd86d91d49ecbe58d99c817/src/HttpClientToCurl/Builder.cs#L136C61-L136C67
from httpclienttocurlgenerator.
Hello @amingolmahalle,
Thank you for your comment. I've received feedback from @kokoabim regarding the handling of header values in the code. The suggestion is to use string.Join("; ", header.Value) instead of header.Value?.FirstOrDefault() to accommodate cases where headers may have multiple values.
I'll make the necessary adjustments to the code to address this issue. Once the changes are complete, I'll create a pull request for your review.
If you have any specific preferences or additional considerations, please let me know.
Appreciate your attention to this matter.
from httpclienttocurlgenerator.
Hello @Sabermotamedi.
This issue is assigned to you.
Thanks.
from httpclienttocurlgenerator.
Related Issues (19)
- Show more details in case of errors HOT 2
- Add fluent assertions to xml tests
- Add fluent assertions to json tests
- Why BaseUrl of HttpClient is mandatory? HOT 1
- Query params not escaped in url, resulting in invalid curl command. HOT 1
- Refactor Unit Tests to use xUnit Framework HOT 1
- 📝 Integrate EditorConfig for Code Consistency
- Proposal: Add Sample Projects for Better Documentation
- Quote the URL HOT 2
- Add cURL compressed command-line option HOT 12
- Use readme.md file in nuget readme HOT 3
- Seperate Test and Source Folder HOT 1
- add pre-commit and pre-push files to curl generator HOT 2
- Adding tests for input config for different scenarios(show in the console, write in a file and put into string variable) HOT 2
- Exclude `Content-Length` from curl HOT 1
- Make NuGet package Strongly Named HOT 2
- Refactoring on the Readme file
- Changing the code of some classes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpclienttocurlgenerator.