Plugin error is logged in laravel's log about vscode-laravel-extra-intellisense

[amir9480]

Hi @ashrafkamarudin

First issue:
It's weird because Arr class is an alias class in laravel.
https://github.com/laravel/laravel/blob/c66546e75fcbf208d2884b5ac7a3a858137753a3/config/app.php#L194

Second issue:
About AuthServiceProvider, it's a commented line by default and should not be filled with non-existing
class.
https://github.com/laravel/laravel/blob/c66546e75fcbf208d2884b5ac7a3a858137753a3/app/Providers/AuthServiceProvider.php#L16

Third issue:
It's weird, I used this method to get middleware names.
You can see it's definition here:

https://github.com/laravel/framework/blob/5b756ae90a16ca224ad5283956eca6d3e15aa278/src/Illuminate/Foundation/Http/Kernel.php#L434

Make sure you are using the latest version of laravel in your project.

[ashrafkamarudin]

I see. yes i've check the files it seems that these changes is applied to Laravel's 5.8 and above. So the one who used Laravel 5.7 and below will get these errors in their laravel log.

Do you plan on supporting old laravel ?

also btw, I think you should update your log handler seems to not be working as it logs to laravel's log file on this line

vscode-laravel-extra-intellisense/src/helpers.ts

Line 66 in 740dd4f

" $this->app['log']->setHandlers([new \\Monolog\\Handler\\NullHandler()]);" +

maybe you can try it with

$this->app['log']->getLogger()->pushHandler(new \\Monolog\\Handler\\NullHandler());

[amir9480]

@ashrafkamarudin

No, I do not have any plans to support older versions of laravel.
I highly recommend you to update your laravel application to the latest version.

Also about this handler please make a pull request to fix, So I can check and use your solution, thanks.

[ashrafkamarudin]

Alright, I'll do it.

[mwkcoding]

@amir9480 You should consider using FQN instead of assuming people have their aliases registerered.
Some people might upgrade their Laravel projects without updating configs cause it's never included in the upgrade guides unless it's a breaking change. Aliases will NEVER be a breaking change in configs. They're made for the convenience of the developer. They're optional, not required.

[amir9480]

@mwkcoding
Hi
I don't understand what you mean.

Can you please send me a sample code to disable the Laravel log?
The current code is:
https://github.com/amir9480/vscode-laravel-extra-intellisense/blob/master/src/helpers.ts#L80

[mwkcoding]

@amir9480 I mean for example with helper classes like Arr https://github.com/amir9480/vscode-laravel-extra-intellisense/blob/master/src/AuthProvider.ts#L55
Instead of expecting there to be an alias for it in the project, use the FQN Illuminate\Support\Arr. That would solve this error on Laravel ^6.0 which might not have the class registered as an alias in their config from upgrading from Laravel 5.

[amir9480]

@mwkcoding
Got it.

Contributions are welcome.
Please fix this and make a pull request.