GithubHelp home page GithubHelp logo

Comments (7)

grs avatar grs commented on August 16, 2024

What happens to the state of the connection and session containing the link?

Would forcing a disconnect work for example?

from rhea.

anthonyvercolano avatar anthonyvercolano commented on August 16, 2024

We call this only when the connection is already down. We're just trying to clean up. Depending on whether we are retrying operations, we would subsequent to this, be trying to open up the connection again and creating new sessions and links.

from rhea.

grs avatar grs commented on August 16, 2024

So the idea is to prevent the link being reattached automatically when the connection reconnects?

from rhea.

anthonyvercolano avatar anthonyvercolano commented on August 16, 2024

Essentially. We're also trying to clean up in the hopes that the objects representing this link will get gc'd away.

from rhea.

anthonyvercolano avatar anthonyvercolano commented on August 16, 2024

Although, you also raise the interesting point, that I would probably want something similar for the session I opened. I would be recreating that also.

from rhea.

grs avatar grs commented on August 16, 2024

Ok, understood.

from rhea.

grs avatar grs commented on August 16, 2024

I've created a PR with a suggested change: #68. It adds a remove() method to link and session that can be used to clean them up if desired. Does that look like what you need?

from rhea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.