Comments (3)
Ah, I see! what clang-tidy says makes a lot of sense!
So I think the origin of that first if (std::abs(cfz-csz) <= 1e-14)
comes from Stone et.al 2018 paper (https://iopscience.iop.org/article/10.1086/588755). On page 171, it says "In the degenerate case in which Ca=Cax=a, so cfz =csz
, then equation (A16) becomes alf= 1
and als= 0
."
So the question is, if that first if is removed, then for that case when cfz=csz
, would these terms alf
and als
approach the "theoretical" 1 and 0 or numerically have values far from it? or should the second and third ifs only be done if cfz
is "significantly" different than csz
and then avoid overwriting?
I'm not sure if trying to not overwrite the first if
matters, since the tests in #2880 are passing
from castro.
I just saw the comment on the corresponding file of #2880 addressing this and the suggested change solves this already
from castro.
yeah, I think the PR fixes this issue.
from castro.
Related Issues (20)
- use reduceop array to shorten reduces in sum_utils
- How to configure a composite solve with hypre's linear solvers? HOT 4
- split c-linter action in 2 HOT 2
- consider using AMReX if constexpr parallel
- gpu running slower than cpu for subchandra problem HOT 4
- amrex::Error::0::Error: initial data has rho <~ small_dens !!! HOT 4
- setup a ASAN CI test HOT 1
- VODE failure in Detonation with self-consistent NSE HOT 7
- test performance issue with GCC > 12 HOT 1
- still have issues with pressure in 1-d momentum fluxes HOT 1
- illegal memory access error subchandra on CUDA HOT 4
- make_radial_gravity errors after retry w/ subcycling disabled HOT 4
- potentially more issues with reties and amr.subcycle_mode = None HOT 2
- For retry w/ MHD, we need to backup B
- chk files are not compatible between different compiler systems. HOT 1
- amrex::Error::0::Error: initial data has rho <~ small_dens !!! HOT 8
- Riemann passive confusion
- add ability to print warnings from GPUs HOT 2
- non-convergence in the Riemann solver should trigger retry
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from castro.