GithubHelp home page GithubHelp logo

mhd_eigen values are unused about castro HOT 3 CLOSED

zingale avatar zingale commented on August 13, 2024
mhd_eigen values are unused

from castro.

Comments (3)

guadabsb15 avatar guadabsb15 commented on August 13, 2024

Ah, I see! what clang-tidy says makes a lot of sense!

So I think the origin of that first if (std::abs(cfz-csz) <= 1e-14) comes from Stone et.al 2018 paper (https://iopscience.iop.org/article/10.1086/588755). On page 171, it says "In the degenerate case in which Ca=Cax=a, so cfz =csz , then equation (A16) becomes alf= 1 and als= 0."

So the question is, if that first if is removed, then for that case when cfz=csz , would these terms alf and als approach the "theoretical" 1 and 0 or numerically have values far from it? or should the second and third ifs only be done if cfz is "significantly" different than csz and then avoid overwriting?

I'm not sure if trying to not overwrite the first if matters, since the tests in #2880 are passing

from castro.

guadabsb15 avatar guadabsb15 commented on August 13, 2024

I just saw the comment on the corresponding file of #2880 addressing this and the suggested change solves this already

from castro.

zingale avatar zingale commented on August 13, 2024

yeah, I think the PR fixes this issue.

from castro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.