GithubHelp home page GithubHelp logo

false positive for operator >= about ck3-tiger HOT 5 CLOSED

amtep avatar amtep commented on August 25, 2024
false positive for operator >=

from ck3-tiger.

Comments (5)

ProZeratul avatar ProZeratul commented on August 25, 2024

This is not a false postivie, this is value assignment to tell the trigger the value of TIER will be scope:host.highest_held_title_tier , the value comparison is done in the trigger itself

So it should be a simple TIER = scope:host.highest_held_title_tier

from ck3-tiger.

amtep avatar amtep commented on August 25, 2024

The error message is subtly wrong though :) It says expected TIER = or ?=
But ?= would be wrong here too.

from ck3-tiger.

amtep avatar amtep commented on August 25, 2024

Specifying exactly where ?= is valid will be a big task...

from ck3-tiger.

amtep avatar amtep commented on August 25, 2024

There's also a question, if this >= syntax is harmless should we still warn about it?
I'm leaning toward "yes warn", because someone might think <= will also work and it won't.

from ck3-tiger.

amtep avatar amtep commented on August 25, 2024

I adjusted the error messages so that it will no longer imply ?= can be used here. I think that ties up the last of the threads from this report

from ck3-tiger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.