GithubHelp home page GithubHelp logo

Usage and examples about hyddown HOT 8 CLOSED

mefuller avatar mefuller commented on July 1, 2024
Usage and examples

from hyddown.

Comments (8)

mefuller avatar mefuller commented on July 1, 2024

The exact meaning/definition of specified h, constant U, and constant Q heat flux is lacking (manual.md).

I am also making a number of edits to spelling and grammar in the manual, which I will submit as a PR.

from hyddown.

andr1976 avatar andr1976 commented on July 1, 2024

I have tried to address the meaning of specified h/ const U, constant Q in the manual

from hyddown.

mefuller avatar mefuller commented on July 1, 2024

@andr1976 I'll take a look shortly.
Going forward, you may want to make such changes in a separate branch and submit a PR and request me (or another reviewer) so that the differences are obvious and easily commented upon

from hyddown.

andr1976 avatar andr1976 commented on July 1, 2024

@mefuller, noted I have created a separate branch https://github.com/andr1976/HydDown/tree/revise-mefuller to address e.g. comments in the code / doc strings etc. I will let you know when to review

from hyddown.

andr1976 avatar andr1976 commented on July 1, 2024

@mefuller , I have added you as collaborator in order to be able to invite you to review oull requests. Once you accept I will send a PR for review

from hyddown.

bocklund avatar bocklund commented on July 1, 2024

I also think it would be nice to have something like a quickstart. The instructions in the README and manual to

Run the code as simple as:

python main.py input.yml

does not work if users install from pip instead of from the source tree, since they don't have access to those files. The instructions could be more clear for users who may not be very experienced and don't know where to find the input.yml and main.py files.

from hyddown.

andr1976 avatar andr1976 commented on July 1, 2024

@mefuller, let me know if you have more comments I should address or revise the paper/code, also consider closing this issue.

from hyddown.

mefuller avatar mefuller commented on July 1, 2024

Everything looks good

from hyddown.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.