GithubHelp home page GithubHelp logo

Comments (8)

andreamazz avatar andreamazz commented on June 5, 2024 1

Pushed a minor update that filters the followers:

let followersHeight = self.followers.filter { $0.direction == .scrollUp }.compactMap { $0.view?.frame.height }.reduce(0, +)

from amscrollingnavbar.

alexookah avatar alexookah commented on June 5, 2024 1

nice @andreamazz
great job
closing the issue

from amscrollingnavbar.

alexookah avatar alexookah commented on June 5, 2024 1

PL merged
Thanks so much @andreamazz

from amscrollingnavbar.

andreamazz avatar andreamazz commented on June 5, 2024

Hey @alexookah
check out master for a fix. I've added scrollToTop to the showNavbar call, optional, default set to false

from amscrollingnavbar.

alexookah avatar alexookah commented on June 5, 2024

@andreamazz
It works perfect when there are no followers.
With follower it needs the height of followers.
How to calculate that?

from amscrollingnavbar.

alexookah avatar alexookah commented on June 5, 2024

@andreamazz
You forgot to handle the scrollToTop inside the function ?

i tried this for one follower which seems ok
let size = CGPoint(x: 0, y: -(self.followers.first?.view?.frame.height ?? 0))

maybe create a computer variable that returns for all followers the height?

from amscrollingnavbar.

andreamazz avatar andreamazz commented on June 5, 2024

Right, added to master the followers height and fixed the missing check:
7744693

from amscrollingnavbar.

alexookah avatar alexookah commented on June 5, 2024

@andreamazz
Sorry for all the fuzz.
After checking with my configuration i had to add an additionalScrollToTopOffset
made a pull request for this.

#378
hope its not too late.

from amscrollingnavbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.