Animation is applied on sheet view and is propagated down to the content about partialsheet

[AndreaMiotto]

Thank you for your feedback, can you provide a starting point with your code.
Anyway I will try to give it a look and modify it.

[NeverwinterMoon]

Hi!

My actual use case is slightly different and looks even worse, but this example hopefully gives an idea of what's wrong: https://github.com/NeverwinterMoon/PartialSheet-animation-issue

[AndreaMiotto]

Should be fixed, give it a try with v2.1.6

[NeverwinterMoon]

Well, this certainly does fix an issue when one doesn't want animations in the content view at all, but now it disables animations altogether for the content. Even if I use explicit property animations in the content view, they won't work, as the parent explicitly disables the animations for all the children views...

As I noted before, using any animation modifier on the parent (be it nil or anything else) is not a good way to go, as it messes up the children views.

[AndreaMiotto]

ok you are right, but then I don't know how to fix this, I need to apply the animation on the parent:

.animation(self.dragState.isDragging ?
                        nil : .interpolatingSpring(stiffness: 300.0, damping: 30.0, initialVelocity: 10.0))

otherwise when you open and close the partial sheet the effect it's very bad

[NeverwinterMoon]

I tried doing a similar thing (to have nice effect for sheet appearing/disappearing) differently: by using .transition.

var body: some View {
    ZStack {
      if isOpen {
        background
          .transition(AnyTransition.opacity.animation(.easeInOut))

        GeometryReader { proxy in
          self.card(proxy: proxy)
        }
          .transition(.move(edge: .bottom))
          .onDisappear {
            self.opacity = 0.65
            self.dragStateClone = .inactive
          }
      }
    }
  }

I have separate transition for the slide up and for background fading in. Both are animated using property animation (on @Binding var isOpen: Bool), so they don't affect any children views.

So, it would be triggered like that:

withAnimation(.interpolatingSpring(stiffness: 300.0, damping: 30.0, initialVelocity: 10.0)) {
   self.isOpen = true
}

[AndreaMiotto]

would you like to make a PR? at the moment I'm busy on other stuffs

[AndreaMiotto]

I really can't see how to apply your code to the partial sheet modifier

[NeverwinterMoon]

I could take a stab at a PR but it would also take me some time, as I am overly occupied with stuff at work.

Otherwise, the change might not be that trivial. The code I posted I've applied to a simplified version of PartialSheet and it is working really nicely with all the required animations on the sheet itself but without affecting the animations of the sheet content.

[styrken]

Hi @NeverwinterMoon, are you still up for the PR?

[1337domz]

I have a somewhat working version which allows you to use explicit animations again (removes the .animation modifier):

https://github.com/1337domz/PartialSheet

At the moment:

• It will only work on iOS 14, as I am using the .onChange(of:) modifier. There is probably a way to do this differently to make it iOS 13 compatible.
• When the keyboard first gets shown it doesn't seem to adjust the height properly, I'm not sure why. I don't need the keyboard functionality so I didn't spend too much time trying to fix it.

Other than that, it seems to function as expected with the examples. I added a new example of an animation, that doesn't work with the currently released version. Maybe someone else can build upon this?

[eliottrobson]

I noticed that the animations were clunky when showing and hiding the sheet so I also started to have a look at this. I have a working version with explicit animations in that pull request. I have also included an example with working animations in the sheet (implicit, explicit and none) all working as expected.

[styrken]

Awesome guys! I will have a look at it