arrays with elements <4 bytes cause MultiRoaringBitmap.jaccard_dist() seg fault about roaringbitmap

[andreasvc]

There are two issues with your code. You refer to index 3 which is out of bounds because len(mrb) == 3. Secondly, you pass arrays to jaccard_dist which do not have type code 'L', as in the docstring example.

It is of course possible to check for these things, but the idea was to minimize overhead.

[daveuu]

Fair enough. Do you think the 'Q' arrays will ever give a wrong result even if they don't cause a crash? I appreciate the design choice for not checking types in the interests of speed though, so I suppose it doesn't matter what the output is: it's up to the user to check their input.

[andreasvc]

L and Q happen to be the same size on Intel 64-bit, so the results will always be identical. L and Q probably differ when you run on 32-bit or another platform. Checking the type of the arrays wouldn't be a problem, it happens only once per call (as opposed to checking whether indices are out of bounds). In any case the docstring is now more explicit.