GithubHelp home page GithubHelp logo

Comments (6)

andreiapostoae avatar andreiapostoae commented on June 27, 2024

I confirm that it is an inconsistency between those two. However, it has no impact in the prediction value.

To sum it up:

  • query.py: result[0][1] = probability of the 1 class to be true (radiant_win) - it's correct
  • augment_one_hot.py: strictly speaking, as I do not make queries, but only check the accuracy, how I encode the states is irrelevant

However, I agree that symmetry should be achieved, so I will update the .ipynb by fixing this issue and introducing comments. Thanks a lot for observing the issue!

from dota2-predictor.

mdfwn avatar mdfwn commented on June 27, 2024

I'm not entirely convinced yet. If your y_train encodes that y_train[:,0] = chance of radiant_win and y_train[:,1] = chance of dire_win (second column), how does result[0][1] (second column) encode the chance of radiant_win? Sorry if this is obvious, I just don't see it.

from dota2-predictor.

andreiapostoae avatar andreiapostoae commented on June 27, 2024

I realize that I failed to explain properly. What I meant was that the notebook and the rest of the project have nothing to do with each other.

You can consider the query.py encoding the right version with result[0][1] meaning the chance of radiant_win, and the one from the notebook the wrong version. However, since in the notebook we don't make queries regarding radiant/dire, it has no impact on the accuracy.

I will fix the notebook anyway so further confusion is avoided. I hope I was clear enough this time, but if I was not, feel free to ask.

from dota2-predictor.

andreiapostoae avatar andreiapostoae commented on June 27, 2024

Basically, at the moment, logistic regression (query.py) predicts [dire_chance, radiant_chance] and the notebook predicts [radiant_chance, dire_chance].

from dota2-predictor.

mdfwn avatar mdfwn commented on June 27, 2024

Oh alright now I understand. I used the notebook code to create x_train and y_train for my model, but you created it differently for your model, I assume, so for you it is consistent. Thanks for clearing it up.

from dota2-predictor.

andreiapostoae avatar andreiapostoae commented on June 27, 2024

I added two better explained IPython notebooks in the "experiments" folder. The one hot encoding was removed such that there is no more confusion.

from dota2-predictor.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.