Incorrect syntax near ';'. about efbulkinsert

[andreisabau]

Hello @boginw
It seems that your table doesn't have any identity column(s) which are generated by the database on insert.
Since the query is formed with those columns in mind (you can check it out here the code https://github.com/andreisabau/EFBulkInsert/blob/master/EFBulkInsert/BulkInsertExtension.cs#L100), the generatedColumnNames variable is empty and the query is ending in ",".
I should definitely add support for tables without any db generated columns.
In the meanwhile you could try to add/make a column as an identity, let me know if that works.

[boginw]

Hi @andreisabau
I'm quite new to MSSQL and Entity Framework. Is it correct that identity column(s) are primary keys? If so, I have composite keys added like such HasKey(ci => new { ci.CatalogueId, ci.LineId });. Is this what you mean by Identity column(s)?

[andreisabau]

@boginw identity columns are different than primary keys.
You can read more here: https://dba.stackexchange.com/questions/46373/is-it-recommended-to-use-identity-as-an-alternative-to-primary-key or https://stackoverflow.com/questions/4293426/whats-the-difference-between-a-primary-key-and-identity - these explanations are better than what I could give.

What your table is missing (for EFBulkInsert to work in this version) is a column marked as an identity which basically auto increments the column's value on every INSERT.
From my knowledge the HasKey method makes the column as an identity only if it's used for a single key, not a composite one.
You can make other columns (int or bigint) as identity columns using the HasDatabaseGeneratedOption method or DatabaseGenerated attribute.

Property(x => x.ColumnName).HasDatabaseGeneratedOption(DatabaseGeneratedOption.Identity);

// OR

[DatabaseGenerated(DatabaseGeneratedOption.Identity)]
public int ColumnName { get; set;}

I will also change EFBulkInsert to support tables without identity columns in a new version.

[boginw]

I followed your instructions, and got a bit further. The bad news is that it still wont run. I've added an identity column like you suggested. I'm now getting an System.Data.SqlClient.SqlException exception with the message Invalid object name 'CatalogueLineItem', which is understandable, since no table is called that. Instead the table is called CatalogueLineItems. Is there any way to specify the table name, or something similar?

[andreisabau]

Fixed in the latest version available at https://www.nuget.org/packages/EFBulkInsert/0.3.0