[Question] using react-env for S3 based deployments about react-env

[shirbr510]

as far as it seems, nothing actually happens unless I'm actively running the nginx image...

I guess I'll need to run react-env --dest manually after all 🤷‍♂ 😄

[andrewmclagan]

Hi. You do not have to use the docker image. This is just to make life easier for those who want to deploy in a docker environment.

The core of this library is a node binary that builds the env.js environment file. That’s all you need. I’m not 100% familiar with deploying to s3... although the core question is: Do you even have environment variables available on s3?? My assumption would be no as you need a node runtime anyway not static js.

Please describe where your env bars come from / config.

[shirbr510]

well, it's basically the same
you solution revolves around hosting env.js file that you can access from window._env
same will happen if you host an env.js via an s3 bucket, it will work exactly the same

my point in my question is that it seems like you need more examples on how to build your images with various platforms (and obviously, support nginx OOTB)

I actually dug into the way you are using it in nginx and figured out how to implement it all rather neatly

the only thing that I'm missing is that our deployment flow isn't based on the NODE_ENV variable due to it's implication on node performance, so we rather use a variable called ENV or REACT_APP_ENV

as far as I can see, the only issue with this is this line: https://github.com/beam-australia/react-env/blob/6b1471fcca43b5863cfe22db2927bb0e492bab6c/packages/node/dist/cli-index.js#L7

[andrewmclagan]

That’s a great point we should add some more examples with docker, serverless etc...

We actually do the same. We have a variable called PLATFORM_ENV so we can still have node in production on our staging servers

[andrewmclagan]

Any thoughts on s3 documentation?

[shirbr510]

@andrewmclagan if that's the case, let's extract the NODE_ENV parameter to a cli parameter that can default to NODE_ENV 😄

I can try and open a PR for you :)

[shirbr510]

regarding S3 docs, there's not much to it tbh
the moment you get a dist that includes the correct env.js in the build folder, you should be good to go 👍

I can try and make an example based on a very simple CRA 😄

but as you said, issues/goals for docs per common deployment way can be very nice 🎉

[andrewmclagan]

closing as stale