Error with Git 1.8.2.1 about homeshick

[andsens]

Going to take a look at this tonight

[andsens]

This should do the trick. I did some half-assed version grepping as if I committed mid-code or something.

[mroth]

I believe this change introduced a new error if the user has hub installed/aliased.

$ homeshick check
        error could not determine git version

$ git --version | cut -d ' ' -f 3
1.8.2
1.10.6

$ git --version
git version 1.8.2
hub version 1.10.6

Perhaps it just needs a head -n1 in the pipeline?

[andsens]

hah, oh wow. I didn't think of that one :-)
the head -n1 is just a patch, I think I need to find a git plumbing command for this.

[andsens]

Hold on, isn't this because you have aliased hub as git?!
I couldn't help but think that adding the version number of an extension to the extended program is bad practice and from what I can tell, hub doesn't extend git in any way.

[mroth]

@andsens yes, hub is specifically designed to "wrap" git to extend it's functionality, and most installations recommend aliasing it in that way (in fact, oh-my-zsh automatically does that, Github's boxen program automatically does it, etc). see http://defunkt.io/hub/ and that's how it's recommended to be used

I agree wrapping the --version output like that is a bit weird... but that's what they've done for whatever reason.

[andsens]

Hm ok. I think we go at it with grep though (so a bit like before the fix)

git_version=$(git --version | grep 'git version' | grep -oE '([0-9]+\.){3}([0-9]+)?')

Like this?

[mroth]

Hmm.. that regex doesn't seem to match on vanilla git 1.8.2, since it expects each digit to end in a period (e.g. it matches 1.8.2. but not 1.8.2). My regex fu isn't quite up to knowing what would fix that most simply...

What about git --version | grep 'git version' | cut -d' ' -f3 ? That should find the git version line no matter what order it appears in and then just grab the version column despite what characters it contains (which would be good if there ever exists version numbers such as 1.8.3a -- not sure if that is likely or not.)

BTW, it looks like the line which may also really have to be modified is not the shell capture itself but the following line
if [[ ! $GIT_VERSION =~ ([0-9]\.){3}[0-9] ]]; then
becauseI believe it has that same problem with requiring three .s when a three-arg version number only has two.

[andsens]

which would be good if there ever exists version numbers such as 1.8.3a -- not sure if that is likely or not

Trouble is, then version_compare won't work anyways... So this check is really only to make sure users don't get a weird error in the middle of the script.

[andsens]

This should do it.

[mroth]

Seems to be working here, thanks! 👍