Git is loud about homeshick

[untitaker]

Maybe redirecting the output into a tempfile, which gets outputted when git exits with an exitcode != 0 ?

[andsens]

I'm not too fond of using temporary files for that. Maybe homeshick could save the output in a variable using a subshell. I don't think you can check the exit code of a process in a subshell though.
Maybe we can do this instead?

output=$(git clone --quiet $git_repo $repo_path; echo "Exit code was $?")
if [ ${output:${#output}-1} != 0 ]; then
    err "Unable to clone $git_repo. Git says:" "$output"
fi

[andsens]

Just realised this doesn't take of exit codes 10,20,30 etc.

output=$(git clone --quiet $git_repo $repo_path; echo "Exit code was $?")
if [ "${output:${#output}-1}" != " 0" ]; then
    err "Unable to clone $git_repo. Git says:" "$output"
fi

[andsens]

Oh, I see...

output=$(git clone --quiet $git_repo $repo_path; exit $?)
if [ $? != 0 ]; then
    err "Unable to clone $git_repo. Git says:" "$output"
fi

Might be a bit easier :-)

[untitaker]

What about stderr?

output="$(git clone $git_repo $repo_path 2>&1)"
if [ $? != 0 ]; then
    err "Unable to clone $git_repo. Git says: $output"
fi

[untitaker]

(in that case we also could omit the --quiet flag, since more information on error is actually better)

[andsens]

Oh yes, that too of course. I just realized that we don't need the exit $? at all. Not sure why I thought the subshell would exit with 0 otherwise.

[untitaker]

git seems to print all output to stderr (!?), so redirecting only stdout to /dev/null and let errors pass through is not possible.

[untitaker]

That said, i would prefer a more verbose output, especially when updating submodules, since i still don't fully trust git's submodule functionality.

[andsens]

Maybe we can introduce a --verbose switch. Saying git submodule cannot be trusted is a very subjective argument for outputting unimportant information to the console.
In addition, knowing how the submodule functionality operates I have to disagree.
I think I will implement this. (unless you can provide a stronger argument?)

[untitaker]

Go ahead 👍

[andsens]

Oh ffs. I get my confusion now. Guess what?

#!/bin/bash
function fn {
    output1=$(test -e nonexistent)
    echo $? # Outputs 1
    local output2=$(test -e nonexistent)
    echo $? # Outputs 0
    local output3
    output3=$(test -e nonexistent)
    echo $? # Outputs 1
}
fn

The local keyword is a command that changes the last exit code. This is why I sometimes couldn't get the proper exit code.