GithubHelp home page GithubHelp logo

Comments (4)

vsudilov avatar vsudilov commented on May 25, 2024

This is due from the fact that the ADS api doesn't return non-existent fields for records, regardless of the fl. The solution is to explicitly set all fields in fl to None independently of the ADS api response.

Thanks for the catch.

from ads.

Morisset avatar Morisset commented on May 25, 2024

Thanks for your answer. I don't see how practically I can change the code to avoid the secondary calls to ADS when volume is None...

from ads.

vsudilov avatar vsudilov commented on May 25, 2024

I'd probably use a defaultdict based on response.params['fl'] here:

https://github.com/andycasey/ads/blob/master/ads/search.py#L265

I assigned myself and I'll take care of it, but if you want to make a PR that's fine too -- just please include tests if you do.

from ads.

Morisset avatar Morisset commented on May 25, 2024

I think it's better if you follow the case, I'm leaving tonight for some holidays ;-)

from ads.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.