GithubHelp home page GithubHelp logo

Comments (3)

Anemolo avatar Anemolo commented on August 17, 2024

Judging by the report and the comments on the related issue. It seems to me that the problem is when getting the naturalwidth/naturalheight of the texture on click. Perhaps with ThreeJS image resize that somehow gets lost or is missing

A possible solution would be to read the image's width/height on img.onload, and caching that in the texture set. The image size doesn't change so it would be virtually the same

I don't have any plans on updating the project. But if you submit a PR I can check it out and merge if it looks all good.

from gridtofullscreenanimations.

Everade avatar Everade commented on August 17, 2024

@Anemolo
Just opened a pull request.
#2

Note:
I've commented the ".needsUpdate" triggers, because three.js no longer supports resizing of textures if already initialized.

Looking forward to your code review,
thank you.

from gridtofullscreenanimations.

Everade avatar Everade commented on August 17, 2024

@Anemolo
I was able to fix the black/missing texture bug.
So the pull request is now complete and fully working!

from gridtofullscreenanimations.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.