GithubHelp home page GithubHelp logo

Use OS specific system menus about arcadia HOT 14 CLOSED

brodock avatar brodock commented on August 17, 2024
Use OS specific system menus

from arcadia.

Comments (14)

angal avatar angal commented on August 17, 2024

Hi, could you check please if something is changed by testing the last code on repository
(git clone https://github.com/angal/arcadia.git)
I haven't a mac !

from arcadia.

brodock avatar brodock commented on August 17, 2024

arcadia-git-on-osx

still the same ;/

from arcadia.

angal avatar angal commented on August 17, 2024

can you write output typing RUBY_PLATFORM on irb ?

from arcadia.

brodock avatar brodock commented on August 17, 2024

It's the same as in the bottom right of arcadia:

2.1.2 :001 > puts RUBY_PLATFORM
x86_64-darwin13.0
=> nil

from arcadia.

angal avatar angal commented on August 17, 2024

I have tried an alternative way (nearer the actuale code) but it doesn't seem working.
Does the script that you posted work ? Right ?

from arcadia.

brodock avatar brodock commented on August 17, 2024

Yes!

Here is the expected output from the code I sent you:
demo

from arcadia.

angal avatar angal commented on August 17, 2024

Hi, can you check if now the menu works fine on OSX?

from arcadia.

brodock avatar brodock commented on August 17, 2024

a_core.rb at line 1584 is returning a "NoMethodError" undefined method '>' for nil:NilClass which looks like _menubar.index('end') is missing something.

I can't easily copy/paste the stacktrace, so I'm attaching it.
stacktrace

from arcadia.

angal avatar angal commented on August 17, 2024

on my env _menubar.index('end') returns 0 probably in your it returns nil.
retry now please

from arcadia.

brodock avatar brodock commented on August 17, 2024

Awesome, it works now.

There still some small things to fix:

  • Menu itens color/font doesn't match OSX ones. (They are gray, which means that it's inactive, but they do work), and the font isn't the one used by OSX menus. I guess you shouldn't define then if it is OSX).
  • File menu is duplicated (the first one have "Open", and the second one have the other itens).

menu-osx

I would like to start contributing on the other UI fixes to match current view on OSX to the one on your screenshots (running on linux) without bothering you too much. Does the project have a channel on freenode or are you planning on using https://gitter.im/ or anything else like that?

I would probably like to discuss some code architectural alternatives to have a better multi-plataform support, before sending pull requests, if you think it's okay.

Thanks in advance, your project is awesome :)

from arcadia.

angal avatar angal commented on August 17, 2024

So we are on the right street !
Thank for feedback I would appreciate much if you start contributing on this project.
Now I don't use any discussion channel but for me is ok to use https://gitter.im/ .
I have just opened the room https://gitter.im/angal/arcadia
Thanks
Antonio

from arcadia.

angal avatar angal commented on August 17, 2024

The double "File" menu item should be fixed

from arcadia.

angal avatar angal commented on August 17, 2024

Probably menu now is ok!

from arcadia.

angal avatar angal commented on August 17, 2024

This issue can be closed

from arcadia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.