Why not embed '<script src="various.js"></script>' into templateUrl "html" document ? about ui-router

[timkindberg]

Whoa what is going on here? Would you care to clean up your question? I'm not able to follow.

[marcusbo]

Hi Tim,

It looks like I did a copy/paste of some code and this showed up as HTML-speak...

I would like to see that a "templateUrl" can load any "myXxx.html" (partial) file, in which we can have as many times:

<script src="path/MyJavaScriptFile.js">< /script>

or:

<script type="text/javascript">
       SOME JAVASCRIPT CODE HERE
< /script> 

...with embedded controllers and other JavaScript code that run when the "myXxx.html" is loaded.

In other words, the classical ui-router would just need:

$stateProvider
   .state( "myState"  ,  {
         views : {
              "myView" : {
                  templateUrl  :  "myXxx.html",
                  BUT, NO NEED TO STATE THE CONTROLLER HERE, 
                  BECAUSE THE JS CODE IS EMBEDDED IN 'myXxx.html'
               }
           },

Another really "cool" alternative would be to allow us to insert a JS file in the views:

 templateUrl  :  "myXxx.html",
 controllerUrl  :  "myXxx.js"

Thanks,

Marcus

[ksperling]

This does not sound like a good idea to me, kind of the opposite of accepted best practice of separation of concerns etc.

Mind you, you should be able to have script tags in templates, and the code should run at some point after the template is inserted into the DOM, but you won't have any control over when exactly, nor will $state be able to pick up particular constructs like controller functions in the code and somehow magically attach them to the correct states.

If you want to have different developers working on different parts of the app, just split it up into modules that have their own sets of JS files and templates, but bring the JS together via concat/minify at build time.

[marcusbo]

Hi Karsten,

I'm surprised you closed this discussion and wrote the whole thing off as a bad idea. No point in arguing with you on this one, as I don't have the experience or appetite for this.

We are going to find another way, without ui-router, since you don't think its a valid request.

Perhaps the next versions of AngularJS will have something more suitable for multi-view solutions. iu-router doesn't have what it takes here.

Marcus

[ksperling]

@marcusbo I've given you multiple reasons why script tags in templates are a bad idea, and they have nothing to do with ui-router -- core Angular $route / ng-view work in the same way.

If you've got anything constructive to add, feel free to reopen the ticket or submit a pull request. If you think sulky remarks are the right way to get people to do work for you for free you've got a thing or two to learn yet about open source projects (and people in general).