GithubHelp home page GithubHelp logo

Comments (14)

tkrotoff avatar tkrotoff commented on May 27, 2024

Hummm :/

Originally all ui-select directives were elements (E) only => no issue.
The problem is with IE8, the solution proposed by the AngularJS team does not fully work.

If you have a directive that uses one or more directives, then you have no choice than to use attributes (A): angular/angular.js#4020 => clash name with ui.bootstrap.typeahead

And I guess dropping IE8 support considering AngularJS 1.2 supports IE8, is a bit premature.

from ui-select.

tkrotoff avatar tkrotoff commented on May 27, 2024

@andrewboni @ProLoser @chmanie
What do you think about prefixing everything with ui-select-?

<ui-select>
  <match></match>
  <choices></choices>
</ui-select>
<ui-select>
  <ui-select-match></ui-select-match>
  <ui-select-choices></ui-select-choices>
</ui-select>

Most probably Bootstrap-ui will prefix all directives using ui-
AngularJS prefixes their directives using ng-
AngularStrap prefixes their directives using bs-

from ui-select.

chmanie avatar chmanie commented on May 27, 2024

Works for me 👍

from ui-select.

andrewboni avatar andrewboni commented on May 27, 2024

yes, that works, thanks!

from ui-select.

andrewboni avatar andrewboni commented on May 27, 2024

Any proposed timeline on this? I'm going to implement the short-term fix on this for now.

from ui-select.

tkrotoff avatar tkrotoff commented on May 27, 2024

See commit 777c804

from ui-select.

sheerun avatar sheerun commented on May 27, 2024

@tkrotoff Could you release it?

from ui-select.

t8g avatar t8g commented on May 27, 2024

Could you re-build it ?

from ui-select.

WhatFreshHellIsThis avatar WhatFreshHellIsThis commented on May 27, 2024

Just hit this issue myself... +1

from ui-select.

sheerun avatar sheerun commented on May 27, 2024

There's release on my fork if someone really needs it

from ui-select.

sheerun avatar sheerun commented on May 27, 2024

Oh. I see it was released 2h ago... A comment would be nice.

from ui-select.

antillas21 avatar antillas21 commented on May 27, 2024

Hi,

I am still experiencing issues with this... I saw a comment above that a fix was released and available for version 0.8.1, so I updated ui.select to that version... and also, went ahead and updated ui.bootstrap to the latest version (0.11.2).

But even so, I get this whenever a view including the directive is loaded:

Error: [$compile:multidir] Multiple directives [match, typeaheadMatch] asking for new/isolated scope on: <div typeahead-match="" index="$index" match="match" query="query" template-url="templateUrl">

This is my bower.json file:

{
  "name": "merchantUi",
  "version": "0.0.0",
  "dependencies": {
    "modernizr": "2.8.x",
    "angular": "1.2.x",
    "jquery": "1.x.x",
    "angular-animate": "1.2.x",
    "angular-cookies": "1.2.x",
    "angular-touch": "1.2.x",
    "angular-sanitize": "1.2.x",
    "angular-resource": "1.2.x",
    "angular-ui-router": "0.2.x",
    "bootstrap-sass-official": "3.1.x",
    "angular-bootstrap": "0.11.2",
    "angular-loading-bar": "~0.5.2",
    "angular-growl-v2": "~0.7.0",
    "angular-ui-select": "0.8.1",
    "angular-ui-tree": "~2.1.5"
  },
  "devDependencies": {
    "angular-mocks": "1.2.x"
  },
  "resolutions": {
    "angular": "1.2.22",
    "angular-ui-select": "0.8.1"
  }
}

This is my angular app declaration:

angular.module('merchantUI',
      [
        'ngAnimate', 'ngCookies', 'ngTouch', 'ngSanitize',
        'ngResource', 'ui.router', 'angular-loading-bar',
        'app.config', 'angular-growl', 'ui.select',
        'ui.tree',  'ui.bootstrap'
      ]
    )

This is how I'm calling ui-select:

<div class="form-group">
  <label for="states">States Doing Business In</label>
  <ui-select multiple ng-model="userMerchant.selectedStates" ng-disabled="disabled">
    <ui-select-match placeholder="Select states...">{{$item.value}}</ui-select-match>
    <ui-select-choices repeat="state.id as state in formItems.states | filter: { value: $select.search }">
      <div ng-bind-html="state.value | highlight: $select.search"></div>
    </ui-select-choices>
  </ui-select>
  <span class="help-block error" ng-show="companyProfileFormErrors.states" ng-repeat="error in companyProfileFormErrors.states">{{error}}</span>
</div>

and this is how I'm calling typeahead (based on angular-bootstrap docs):

<div class="form-group">
  <label for="states">Assign user to these Locations</label>
  <input type="text" ng-model="modalOptions.args.selectedLocations" typeahead="location for location in modalOptions.args.locations | filter:$viewValue | limitTo:8" class="form-control">
</div>

from ui-select.

dimirc avatar dimirc commented on May 27, 2024

@antillas21 can you put together a plunker to reproduce it?

from ui-select.

antillas21 avatar antillas21 commented on May 27, 2024

@dimirc ... ooh man, this is embarrassing, but I think I have identified the reason behind this...

It's not related to your directive... it's related to a custom directive created in the project, which by the way is named match.

Thanks for your time, and apologies for this incident.

from ui-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.