Comments (12)
valor-software/ng2-file-upload#1092 - the issue regarding compatibility with Angular 8 and Ivy
from ngcc-validation.
@earshinov the ultimate goal of the project is to verify compatibility with Ivy. Currently, we verify partially only build-time compatibility.
Would you open a PR, importing the FileUploadModule
in AppModule
so we can get the build-time failure?
from ngcc-validation.
@mgechev , Yes, I can do it tomorrow.
from ngcc-validation.
Thanks!
from ngcc-validation.
There you go: https://github.com/mgechev/ngcc-validation/pull/289
ERROR in ../../node_modules/ng2-file-upload/file-upload/file-upload.module.d.ts:1:22 - error TS-996002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class
from ngcc-validation.
@earshinov is this issue still relevant? Can you reproduce it with the latest release?
from ngcc-validation.
@earshinov is this issue still relevant? Can you reproduce it with the latest release?
Yes, the issue is still there.
$ ng build ng2-file-upload-ngcc
0% compiling
Compiling @angular/core : module as esm5
Compiling @angular/common : module as esm5
Compiling @angular/platform-browser : module as esm5
Compiling @angular/platform-browser-dynamic : module as esm5
Compiling ng2-file-upload : module as esm5
chunk {main} main.js, main.js.map (main) 654 bytes [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 709 bytes [initial] [rendered]
chunk {polyfills-es5} polyfills-es5.js, polyfills-es5.js.map (polyfills-es5) 450 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.15 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 10.1 kB [initial] [rendered]
Date: 2019-10-12T14:47:54.550Z - Hash: f05777a33fd1635da221 - Time: 27451ms
ERROR in ../../node_modules/ng2-file-upload/file-upload/file-upload.module.d.ts:1:22 - error TS-996002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class
1 export declare class FileUploadModule {
~~~~~~~~~~~~~~~~
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ngcc-validation already uses the latest version of ng2-file-upload npm package, 1.3.0.
They are now looking for a maintainer, so I don't think we will have Ivy compatibility soon.
My PR into ng2-file-upload adding support for Ivy is still open.
from ngcc-validation.
This seems to have been fixed in the latest 1.4.0 release (thx @earshinov).
You can see it passing here, which is a build for PR #451.
from ngcc-validation.
Not working for latest version (1.4.0) with Angular 9.
from ngcc-validation.
Hello same with Angular 9.1
Appears in the NgModule.exports of CoreModule, but could not be resolved to an NgModule, Component, Directive, or Pipe class.
This likely means that the library (ng2-file-upload) which declares FileUploadModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and upd
ate if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
from ngcc-validation.
I am going to close this issue, because the tests in this repo are passing with ng2-file-upload
(see #284 (comment)). If it is failing for you, it is likely something related to your specific setup, but there is not much we can do without a reproduction of the issue (e.g. a repo we can checkout or exact commands to run to reproduce the error).
If it still failing for you (which based on your comments it is 😁), please open a new issue on angular/angular (where the ngcc
code lives) with all the necessary info (including some form of (minimal 🙏) reproduction). Thank you!
from ngcc-validation.
Angular 9.1 I stack with this error:
ERROR in node_modules/ngx-uploader/lib/ngx-uploader.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class.
This likely means that the library (ngx-uploader) which declares NgxUploaderModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
1 export declare class NgxUploaderModule {
~~~~~~~~~~~~~~~~~
from ngcc-validation.
Related Issues (20)
- Transform to workspaces HOT 2
- How do I add my project to the list? HOT 10
- Remove __ngcc_lock_file__ before run compiler HOT 1
- @ionic/angular HOT 7
- ci: Renovate auto-closes PRs for dependencies targeting GitHub commits HOT 2
- ionic-angular HOT 4
- Add ngrx HOT 2
- [NGXS]: @ngxs/router-plugin not working with Ivy HOT 1
- Error: '.' is not recognized as an internal or external command (when running npm run add-project) HOT 2
- [@momentum-ui/angular] Got: 'ERROR in Cannot read property 'visit' of undefined' HOT 5
- mobx-angular broken by removed Renderer HOT 2
- ng2-completer broken from removed Renderer HOT 2
- ng2-material-dropdown broken from removed Renderer HOT 1
- ngx-chips broken from removed Renderer HOT 1
- Failure tracking summary HOT 2
- ngcc ivy cdk/accordion compile error HOT 3
- @nebular/theme: runtime error HOT 1
- Dependency Dashboard
- Why build only NGXS (store, hmr) without router, logger, etc plugin? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngcc-validation.