GithubHelp home page GithubHelp logo

Comments (6)

johnculviner avatar johnculviner commented on September 20, 2024

Hi @randallmeeker, good question. I actually took the external config stuff as a pull from @rolandzwaga and haven't personally tried it yet. It should be working though. I'd love it if you'd find it out and update the docs in a pull with some more examples as I think that sort of functionality is very useful!

from angularagility.

randallmeeker avatar randallmeeker commented on September 20, 2024

So far as I can tell it works for validations only. and does not work with wrapping in markup. In order to wrap in mark up I have to use aa-field-group, but in order to use external config I have to use ng-model. So their not really compatible. I should have time to play with it some more.

from angularagility.

johnculviner avatar johnculviner commented on September 20, 2024

Interesting, yeah keep me posted as you dig in more and lets try to make it as useful as possible for everyone!

from angularagility.

rolandzwaga avatar rolandzwaga commented on September 20, 2024

hey sorry for the late reply. Indeed, the external config won't work with aa-field or aa-field-group. Because, indeed (again), the external config uses the ng-model value to look up its validation info. (aa-label and stuff does work though.)
The issue is a chicken and egg problem, when the external config parses the HTML, it isn't compiled yet, so the aa-field and aa-field-group directives haven't done their magic yet, so there's no ng-model to be found on these elements.
Perhaps I could build in a check specifically for aa-field and aa-field-group attributes and use their values for the validation lookup.
I'll have a look into this once I find some time.

cheers,

Roland

from angularagility.

rolandzwaga avatar rolandzwaga commented on September 20, 2024

ok, so I did a check test and it actually seems to work, just had to add one line of code...
Here's the PR: #53
Like I say, it was a quick fix, without a huge testing effort, so there might be some residual issues, but AFAICS this works the way its supposed to.

cheers.

from angularagility.

johnculviner avatar johnculviner commented on September 20, 2024

Sweet

from angularagility.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.