Comments (6)
Hi @randallmeeker, good question. I actually took the external config stuff as a pull from @rolandzwaga and haven't personally tried it yet. It should be working though. I'd love it if you'd find it out and update the docs in a pull with some more examples as I think that sort of functionality is very useful!
from angularagility.
So far as I can tell it works for validations only. and does not work with wrapping in markup. In order to wrap in mark up I have to use aa-field-group, but in order to use external config I have to use ng-model. So their not really compatible. I should have time to play with it some more.
from angularagility.
Interesting, yeah keep me posted as you dig in more and lets try to make it as useful as possible for everyone!
from angularagility.
hey sorry for the late reply. Indeed, the external config won't work with aa-field or aa-field-group. Because, indeed (again), the external config uses the ng-model value to look up its validation info. (aa-label and stuff does work though.)
The issue is a chicken and egg problem, when the external config parses the HTML, it isn't compiled yet, so the aa-field and aa-field-group directives haven't done their magic yet, so there's no ng-model to be found on these elements.
Perhaps I could build in a check specifically for aa-field and aa-field-group attributes and use their values for the validation lookup.
I'll have a look into this once I find some time.
cheers,
Roland
from angularagility.
ok, so I did a check test and it actually seems to work, just had to add one line of code...
Here's the PR: #53
Like I say, it was a quick fix, without a huge testing effort, so there might be some residual issues, but AFAICS this works the way its supposed to.
cheers.
from angularagility.
Sweet
from angularagility.
Related Issues (20)
- Error messages are duplicated for input-boxes HOT 2
- Problem to notify error in Angular 1.3.16 HOT 2
- Navigate away $modal example? HOT 3
- difference between AngularAgility and AngularAgility.Net? HOT 1
- FormExternalConfiguration and hierarchical viewmodel HOT 4
- what happened to $resetChanged(function() { }); in 0.8.26 HOT 12
- Consider adding angular-agility to NPM? HOT 3
- There are some validation errors: - But none shown in ul HOT 4
- Navigate Away Strategy
- Validation message on two inputs with same name HOT 3
- Changelog Needed HOT 2
- Angular2 HOT 1
- Wrong error handling in aaAjaxInterceptor could create AJAX infinite look HOT 1
- $reset() in latest version (0.8.36) clears the form empty, ignoring previous values
- NavigateAway modal shows up on state change even though form doesn't change HOT 5
- Module not found error when trying to import angular-agility HOT 1
- Submitting twice when aa-submit-form is used with type="submit" HOT 1
- aaNotify not showing notification when directive is inside view of controller HOT 1
- Get label text in ajaxValidationErrorMappingStrategy HOT 2
- $clearErrors - (thisForm.$setUntouched || angular.noop)(); Lost context inside angularjs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angularagility.