GithubHelp home page GithubHelp logo

Comments (4)

LarsSkiba avatar LarsSkiba commented on August 21, 2024

Further minimized example:
image

	Clipper2Lib::ClipperOffset offset;
	Clipper2Lib::Paths64 closedPaths = {
		{{667680768, -36382704},
		 {737202688, -87034880},
		 {742581888, -86055680},
		 {747603968, -84684800}}};

	Clipper2Lib::Paths64 solution;
	offset.AddPaths(closedPaths, Clipper2Lib::JoinType::Miter, Clipper2Lib::EndType::Polygon);
	offset.Execute(-249561088, solution);

from clipper2.

LarsSkiba avatar LarsSkiba commented on August 21, 2024

7714d940ca86eb7cc8cf5f9eda2b1486daf32cb1
caused the regression

from clipper2.

LarsSkiba avatar LarsSkiba commented on August 21, 2024

This tolerance does not seem to be sufficient.

if (cos_a < 0.99) path_out.push_back(path[j]); // (#405)

In this example 0.996268 does cause the issue.

from clipper2.

LarsSkiba avatar LarsSkiba commented on August 21, 2024

I changed the tolerance to 0.999 which is consistent with the tolerances used in surrounding code and updated the pull request.

from clipper2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.