Comments (9)
Hi,
This change was made a while ago to be consistent with how callables are set in
other modules.
Version 1.8 - June 26, 2011
===========================
- webap2_extras.i18n: the functions passed to I18nStore.set_locale_selector()
and I18nStore.set_timezone_selector() now receive (store, request) instead of
(request, store), for consistency with the router custom callables.
So the current i18n module actually has inverted parameters.
Sorry if this caused you trouble... I've been taking care to not add
incompatibilities like this one. Do you suggest making the inverted parameters
backwards compatible or can I close this ticket?
Original comment by rodrigo.moraes
on 10 Aug 2011 at 4:26
- Added labels: ****
- Removed labels: ****
from webapp-improved.
Hi Rogrigo,
I just started using webapp2 just recently so I wasn't quite up to date with
recent changes :) Anyway, I don't suggest anything, I was merely pointing out
the inconsistency in the docs as I'm sure there will be others making the same
mistake I made.
Original comment by [email protected]
on 10 Aug 2011 at 4:36
- Added labels: ****
- Removed labels: ****
from webapp-improved.
The docs are up-to-date to latest release. You are using a pre-1.8 version,
when the arguments were indeed inverted.
Original comment by rodrigo.moraes
on 10 Aug 2011 at 4:49
- Added labels: ****
- Removed labels: ****
from webapp-improved.
No, I am using webapp2-2.2.3.zip. If store is the first argument to
locale_selector the docs are definately not up to date.
Original comment by [email protected]
on 10 Aug 2011 at 5:18
- Added labels: ****
- Removed labels: ****
from webapp-improved.
Hmmm... Maybe you are reading a cached version? This is what I see there:
(sorry, copy & paste mess)
set_locale_selector(func)[source]
Sets the function that defines the locale for a request.
Parameters: func – A callable that receives (store, request) and returns the
locale for a request.
set_timezone_selector(func)[source]
Sets the function that defines the timezone for a request.
Parameters: func – A callable that receives (store, request) and returns the
timezone for a request.
Original comment by rodrigo.moraes
on 10 Aug 2011 at 5:27
- Added labels: ****
- Removed labels: ****
from webapp-improved.
Look in the parameter list for webapp2_extras.i18n.default_config at the top
of the page :)
/F
Original comment by [email protected]
on 10 Aug 2011 at 5:33
- Added labels: ****
- Removed labels: ****
from webapp-improved.
Ah. Sorry for all the noise. Totally missed that one. Updating it.
Original comment by rodrigo.moraes
on 10 Aug 2011 at 6:00
- Added labels: ****
- Removed labels: ****
from webapp-improved.
No worries. Thanks for making webapp2 so good. :-)
Cheers / Fredrik
locale_selector
Original comment by [email protected]
on 10 Aug 2011 at 6:03
- Added labels: ****
- Removed labels: ****
from webapp-improved.
This issue was closed by revision 71241f3a07c9.
Original comment by rodrigo.moraes
on 10 Aug 2011 at 6:04
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from webapp-improved.
Related Issues (20)
- Webapp2_extras.sessions with backend 'datastore' not working properly HOT 1
- Insecure password hash function
- auth: Rollback Unique DS entries if user.put() fails
- PathPrefixRoute redirects when rest of route is empty but then 404s.
- lazy_gettext doesn't use current locale settings HOT 1
- Only one gettext domain is loadad, others get ignored
- webapp2_extras.auth:invalid cookie signature only warning but no action taken HOT 1
- webapp2_extract.security.hash_password arbitrary hash method can lead to denial of service attack
- plim adapter as a template engine
- uri_for and positional arguments is weird
- webapp2_extras.sessions.SessionDict.__slots__ and SessionDict.container are unused?
- uri_for and Route.build only work in the context of a request
- Doc for webapp2_extras.routes.RedirectRoute has an error
- Broken code in gettingstarted/usingwebapp2.html
- json.dump(data, self.response) is incredibly slow
- Exception when password is unset
- Redirect Route strict_slash fails on POST HOT 1
- Entries under PathPrefixRoute does not show full url when calling uri_for()
- Patch for /docs/tutorials/gettingstarted/usingwebapp2.rst
- Please add a kwarg to the Route object which makes trailing slash optional HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webapp-improved.