@-webkit-keyframes not saved about stylebot

[rduenasf]

That's because the CSSParser used by stylebot doesn't support that rule

[ankit]

Right. It may / may not be hard to add support for this rule, but I'll give it a shot.

[rduenasf]

You could check out the lastest version of the JSCSSP. It has support for many moz-* rules and alike. I think it should be way easier to add the support to that codebase instead of coding the support all by yourself.

[ankit]

Great idea, thanks! I didn't think that the parser was being actively
maintained. The latest version also fixes the 'ul li:nth-child(' crash
issue.

He should really host the code on Github, it'll be much easier to track
changes

On Mon, May 16, 2011 at 11:12 AM, rduenasf <
[email protected]>wrote:

You could check out the lastest version of the JSCSSP. It has support
for many moz-* rules and alike. I think it should be way easier to add the
support to that codebase instead of coding the support all by yourself.

Reply to this email directly or view it on GitHub:
#49 (comment)

[rduenasf]

Grammar:

http://developer.apple.com/library/safari/#documentation/appleapplications/reference/SafariCSSRef/Articles/OtherStandardCSS3Features.html

[rduenasf]

I'm adding support for this now...

[rduenasf]

@ankit I added support for this, also I rewrote almost entirely the css-utils lib to make easier for us to add new rules or change the format of the formatted CSS in the fure.

As a sidenote, we should add a more foolproof way to check if a rule in the stylebot's rules object is either a comment, an error, a webkit-keyframes rule or a normal style rule. Currently we have the comment field (and now __isAnimation too) but those aren't robust ways to check for rule type...

I was thinking we could have named objects just to check this with instanceof/typeof, but that implies to write a rules updater...

[ankit]

Nice.

You're right. This isn't the best way to do this. We can keep this on the back burner and think about it later maybe.