clear all annotations (≠ anno.destroy() ) about annotorious-openseadragon

[rsimon]

Good point. Maybe a clearAnnotations method would be nice.

As far as functionality is concerned: you should get the same effect by setting setAnnotations([]). The empty array should replace the existing annotations if I remember correctly. But I'll double check...

[rsimon]

Yikes. I'm realizing that API-wise, the OpenSeadragon plugin lags further behind the standard version as I thought.

• getAnnotations was indeed broken. I just fixed this in the master branch.
• setAnnotations did not remove existing annotations. I fixed this, too. You can now use setAnnotations to clear the annotation layer, and it's also ok to call it without argument. I.e. both this works:

anno.setAnnotations([]);

anno.setAnnotations();

[rsimon]

Also thanks, I'll check about getAnnotations.

[rsimon]

P.S. I think in terms of API semantics, calling setAnnotations with empty or no argument feels sufficient, and there's maybe no need for an extra clearAnnotations method. But I'm happy to hear dissenting opinions :-)

[rsimon]

P.P.S: that webview client looks awesome! Looking forward to trying this out myself once you've published it.

[atomotic]

fixing getAnnotations() has solved the problem, i've not looked deeply the code but i don't need to setAnnotations[] empty

a quick demo: https://docuver.se/tmp/annotorius.app.mp4
(i'll fix some things on building and packaging and i will publish)

[rsimon]

Fantastic! Both using getAnnotations and then looping through the annotations using removeAnnotation will work. Although, technically, a call to setAnnotations() will be marginally faster, if you are being super-picky about it ;-)

[atomotic]

sorry, i explain better: after your fix of yesterday i don't need anymore to remove the previous annotations on canvas change.
https://github.com/atomotic/annotorius-desktop/blob/master/public/index.html#L34-L43

i published here https://github.com/atomotic/annotorius-desktop
is very very raw and incomplete, i spent on this just a couple of hours

[rsimon]

Ah - of course! Because setAnnotations now properly resets as it should. Thanks for the link! I'll try to install & test drive myself tonight :-)