win_service: is missing service failure handling about ansible.windows

[jborean93]

From @jhawkesworth on Apr 28, 2017 14:44

needs_contributor

[jborean93]

From @jhawkesworth on Sep 15, 2017 17:08

At 19:00 UTC on Tuesday 19 September 2017 this ticket will be processed during the second Windows Sprint,
https://github.com/ansible/community/wiki/Windows:-sprints
we would appreciate if you could join the Sprint to help out with understanding/fixing/closing this issue.

[jborean93]

From @imjoseangel on Aug 10, 2018 08:51

Hi! Is it fine to add the functionality to the module? I can work on it.

[jborean93]

From @jhawkesworth on Aug 10, 2018 09:03

@imjoseangel I haven't heard of anyone working on this. Probably worth asking on #ansible-windows irc channel just in case, but this sounds like it would be good to have this feature if you have some time to work on it.

[jborean93]

From @imjoseangel on Sep 10, 2018 11:07

Hi Guys, past weekend I started working on having this functionality. As I don't like using sc.exe, I'm implementing all the logic using the ten 4-byte useful fields directly from the registry.

To me, is the best way to have full control of the code and keep it idempotent. The first approach is a new module called win_service_recovery with 11 different parameters and its own logic.

Mixing it in the same win_service module could be unmaintainable for developers and unmanageable for users. That is why I have chosen doing this way.

[jborean93]

From @jborean93 on Sep 10, 2018 11:13

@imjoseangel I'm ok with having a separate module for this, probably good as win_service is pretty packed as is. One thing I should say is that try and avoid settings things through the registry. Most of the time registry structures are stable but that is never guaranteed and we can sometimes loose basic checks Windows may have when using the proper interface. I'm sure we can discuss this more once you have a PR or WIP open to talk about it more.

[jborean93]

From @ShachafGoldstein on May 17, 2019 18:01

ansible/ansible#56445

[jborean93]

From @rnsc on May 20, 2019 06:37

@ShachafGoldstein Thanks for the ref. I did implement this into win_service (I didn't stumble upon this feature request when I looked up for service recovery actions and Ansible)

@jborean93 @imjoseangel any thoughts about my PR? :)