win_package: parameter "creates_version" checks "product version" and not "file version" about ansible.windows

[jborean93]

From @jborean93 on Jun 22, 2018 05:52

Technically we are getting the FileVersion, unfortunately it's not the file version that is displayed in explorer. After reading through https://blogs.technet.microsoft.com/askpfeplat/2014/12/07/how-to-correctly-check-file-versions-with-powershell/ it turns out it uses the FilePrivatePart in conjunction with FileVersion to display that value. You can also use FileVersionRaw that contains the full version string as shown by

PS C:\Users\vagrant-domain> [System.Diagnostics.FileVersionInfo]::GetVersionInfo($path2) | Select-Object *


FileVersionRaw     : 60.0.2.6730
ProductVersionRaw  : 60.0.2.0
Comments           :
CompanyName        : Mozilla Corporation
FileBuildPart      : 2
FileDescription    : Firefox
FileMajorPart      : 60
FileMinorPart      : 0
FileName           : C:\Program Files\Mozilla Firefox\firefox.exe
FilePrivatePart    : 6730
FileVersion        : 60.0.2
InternalName       : Firefox
IsDebug            : False
IsPatched          : False
IsPrivateBuild     : False
IsPreRelease       : False
IsSpecialBuild     : False
Language           : Language Neutral
LegalCopyright     : ©Firefox and Mozilla Developers; available under the MPL 2 license.
LegalTrademarks    : Firefox is a Trademark of The Mozilla Foundation.
OriginalFilename   : firefox.exe
PrivateBuild       :
ProductBuildPart   : 2
ProductMajorPart   : 60
ProductMinorPart   : 0
ProductName        : Firefox
ProductPrivatePart : 0
ProductVersion     : 60.0.2
SpecialBuild       :

How we go about fixing/changing this behaviour will be hard as this is a core module and an outright change would break the interface we have in place. I've added it to the agenda for the next Windows Working group meeting to discuss further.

[jborean93]

From @jborean93 on Jun 26, 2018 22:28

It was decided in the latest WWG to add a new module option that specifies what version string to use when comparing creates_version. This has the flexibility of not breaking existing playbooks but allowing people to specify whatever version property they want to compare it to.

In this case it would be something like version_format: FileVersionRaw but the specifics still need to be ironed out.

https://meetbot.fedoraproject.org/ansible-windows/2018-06-26/ansible_windows_working_group.2018-06-26-20.00.log.html

[jborean93]

From @Yvan-Masson on Jun 27, 2018 08:05

This looks great, thanks!
Yvan

how it works now. Im playing with task for git install:

- name: "Git | Install Git"
  win_package:
    path: 'c:\ansible\downloads\Git-2.26.2-64-bit.exe'
    creates_path: 'C:\Program Files\Git\bin\git.exe'
    creates_version: "2.26.2.1"
    arguments: '/SP- /VERYSILENT /NORESTART /SUPPRESSMSGBOXES /FORCECLOSEAPPLICATIONS /LOADINF="c:\ansible\downloads\git_unattended.inf" /LOG="c:\ansible\logs\git_install.log"'
    state: present

and it start install process every run

FileVersionRaw     : 2.26.2.1
ProductVersionRaw  : 2.26.2.1
Comments           :
CompanyName        :
FileBuildPart      : 2
FileDescription    :
FileMajorPart      : 2
FileMinorPart      : 26
FileName           : C:\Program Files\Git\bin\git.exe
FilePrivatePart    : 1
FileVersion        :
InternalName       :
IsDebug            : False
IsPatched          : False
IsPrivateBuild     : False
IsPreRelease       : False
IsSpecialBuild     : False
Language           : English (United States)
LegalCopyright     :
LegalTrademarks    :
OriginalFilename   :
PrivateBuild       :
ProductBuildPart   : 2
ProductMajorPart   : 2
ProductMinorPart   : 26
ProductName        :
ProductPrivatePart : 1
ProductVersion     :
SpecialBuild       :

i'm tryied it with creates_version: "2.26.2" with same result

[jborean93]

Closing as the current logic is most likely relied upon with existing users of the module. If someone wishes to implement such a feature mentioned in #17 (comment) they are more than welcome to add a PR with things like tests but it's not something we are interested in doing ourselves.