Consider adding extern "C" {...} to linenoise.h about linenoise

[thomcc]

I'm not one of the linenoise developers (just a user), but the typical solution to this (that is, using C++-oblivious C libraries from C++) is to wrap the #include in an extern "C". For example, you could write a c++ line-noise wrapper (hypothetically named "linenoise.hpp" as follows:

#ifndef LINENOISE_HPP_INCLUDED
#define LINENOISE_HPP_INCLUDED

extern "C" {
#include "linenoise.h"
}

#endif

Then, you'd include linenoise.hpp instead of linenoise.h everywhere. This will have the same effect as what you did, without requiring a change to the linenoise source.

This will even work if, in the future, an extern "C" block is added to linenoise.h, as they are allowed to nest.

[antirez]

This was fixed merging a PR. Thanks.