Conditional diagram changes causes weird bugs about beautiful-react-diagrams

[obadakhalili]

I've looked into the source code, and it turned out it's an easy fix (assuming I'm not breaking anything):

https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/NodesCanvas/NodesCanvas.js#L16-L21

In the above code snippet, you are updating the nodes coordinates only if the onChange event prop is true, which is always the case given that it's always passed the reference of the function expression onNodesChange:

https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/Diagram.js#L23-L27

https://github.com/beautifulinteractions/beautiful-react-diagrams/blob/c18805eb503b810ec8ec53fc3923d8d6d1ae0d7e/src/Diagram/Diagram.js#L74-L86

Fixing it should be as easy as passing the onChange prop provided by the user to the onChange prop of the NodesCanvas component, instead of passing it the always-true onNodesChange function expression.